Skip to content

test adding a user to a group after the group received a share#35516

Merged
DeepDiver1975 merged 1 commit into
masterfrom
addUserToGroupAfterShareTests
Jun 13, 2019
Merged

test adding a user to a group after the group received a share#35516
DeepDiver1975 merged 1 commit into
masterfrom
addUserToGroupAfterShareTests

Conversation

@individual-it

@individual-it individual-it commented Jun 13, 2019

Copy link
Copy Markdown
Member

Description

test sharing with a group and then adding a user to that group

Motivation and Context

the changed webUI test did do that, but not intentionally. Because that scenario does not work with user-key encryption the test did fail. see owncloud/encryption#132
So this PR make the UI test work in encryption and adds more intentional tests for this scenario

How Has This Been Tested?

🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@individual-it

Copy link
Copy Markdown
Member Author

backport in #35517

@individual-it
individual-it requested a review from sharidas June 13, 2019 09:38
@codecov

codecov Bot commented Jun 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35516 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35516      +/-   ##
============================================
- Coverage     65.93%   65.68%   -0.26%     
  Complexity    18735    18735              
============================================
  Files          1160     1221      +61     
  Lines         63470    70793    +7323     
  Branches          0     1288    +1288     
============================================
+ Hits          41852    46503    +4651     
- Misses        21618    23913    +2295     
- Partials          0      377     +377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (?) 0 <ø> (?)
#phpunit 67.06% <ø> (+1.12%) 18735 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 81.09% <0%> (-8.47%) 0% <0%> (ø)
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (?)
core/js/js.js 55.05% <0%> (ø) 0% <0%> (?)
core/js/systemtags/systemtags.js 90% <0%> (ø) 0% <0%> (?)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8d8e9...b47aa5e. Read the comment docs.

2 similar comments
@codecov

codecov Bot commented Jun 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35516 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35516      +/-   ##
============================================
- Coverage     65.93%   65.68%   -0.26%     
  Complexity    18735    18735              
============================================
  Files          1160     1221      +61     
  Lines         63470    70793    +7323     
  Branches          0     1288    +1288     
============================================
+ Hits          41852    46503    +4651     
- Misses        21618    23913    +2295     
- Partials          0      377     +377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (?) 0 <ø> (?)
#phpunit 67.06% <ø> (+1.12%) 18735 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 81.09% <0%> (-8.47%) 0% <0%> (ø)
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (?)
core/js/js.js 55.05% <0%> (ø) 0% <0%> (?)
core/js/systemtags/systemtags.js 90% <0%> (ø) 0% <0%> (?)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8d8e9...b47aa5e. Read the comment docs.

@codecov

codecov Bot commented Jun 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35516 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35516      +/-   ##
============================================
- Coverage     65.93%   65.68%   -0.26%     
  Complexity    18735    18735              
============================================
  Files          1160     1221      +61     
  Lines         63470    70793    +7323     
  Branches          0     1288    +1288     
============================================
+ Hits          41852    46503    +4651     
- Misses        21618    23913    +2295     
- Partials          0      377     +377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (?) 0 <ø> (?)
#phpunit 67.06% <ø> (+1.12%) 18735 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 81.09% <0%> (-8.47%) 0% <0%> (ø)
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (?)
core/js/js.js 55.05% <0%> (ø) 0% <0%> (?)
core/js/systemtags/systemtags.js 90% <0%> (ø) 0% <0%> (?)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8d8e9...b47aa5e. Read the comment docs.

@DeepDiver1975
DeepDiver1975 merged commit 6e64b99 into master Jun 13, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the addUserToGroupAfterShareTests branch June 13, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants