Enhance re share tests#35521
Merged
Merged
Conversation
phil-davis
force-pushed
the
enhance-reShare-tests
branch
from
June 13, 2019 15:01
16745dc to
a99a646
Compare
Codecov Report
@@ Coverage Diff @@
## master #35521 +/- ##
=========================================
Coverage 65.68% 65.68%
Complexity 18735 18735
=========================================
Files 1221 1221
Lines 70793 70793
Branches 1288 1288
=========================================
Hits 46503 46503
Misses 23913 23913
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35521 +/- ##
=========================================
Coverage 65.66% 65.66%
Complexity 18756 18756
=========================================
Files 1222 1222
Lines 70872 70872
Branches 1289 1289
=========================================
Hits 46540 46540
Misses 23954 23954
Partials 378 378
Continue to review full report at Codecov.
|
phil-davis
force-pushed
the
enhance-reShare-tests
branch
3 times, most recently
from
June 14, 2019 07:34
78bb2b0 to
11709a8
Compare
phil-davis
marked this pull request as ready for review
June 14, 2019 09:46
phil-davis
requested review from
dpakach,
individual-it,
paurakhsharma and
skshetry
June 14, 2019 10:16
individual-it
requested changes
Jun 14, 2019
phil-davis
force-pushed
the
enhance-reShare-tests
branch
from
June 14, 2019 13:07
11709a8 to
6267333
Compare
Contributor
Author
|
@individual-it random commented-out lines have been removed. |
Member
|
CI failure unrelated, restarting |
individual-it
approved these changes
Jun 14, 2019
phil-davis
force-pushed
the
enhance-reShare-tests
branch
from
June 15, 2019 01:08
6267333 to
43dcdd1
Compare
Contributor
Author
|
Backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjust test scenarios so that
user0has skeleton files, and other users (who receive shares) do not have skeleton files. This makes the test sequences a bit easier, because the received share names do not have(2)on them.Add some extra
Thensteps to existing scenarios to check that the correct share and reshare recipients can or cannot see the shared file/folder. This helps verify that the sharing and resharing combinations really are working, and not just that some OCS/HTTP status codes were as expected.Add more combinations of resharing with less, the same and more permissions of the received share, and of a sub-folder in a received share.
Add scenarios for resharing and then (attempting to) update the re-share to have more/same/less permissions.
Add scenarios for creating a public link share of a received share. Make sure that you can't give more permissions in the public link share then what you received from the original sharer.
Added 2 scenarios for issue Permission of reshare cannot be increased #35528 related to trying to increase the permissions on a reshare, where you are just increasing the permissions to a level that should be allowed.
Added various combinations of steps for "the public downloads file" with a without password, and "the public should be able to download file" etc that were missing. There were already steps that did this in some combinations, and checking ranges of bytes in the file etc.
Related Issue
https://github.com/owncloud/enterprise/issues/3364
Motivation and Context
How Has This Been Tested?
Local acceptance test runs
Types of changes
Checklist:
Open tasks: