Skip to content

webUISharingExternal use no skeleton#35534

Merged
DeepDiver1975 merged 1 commit into
masterfrom
webUIExternal-no-skeleton
Jun 17, 2019
Merged

webUISharingExternal use no skeleton#35534
DeepDiver1975 merged 1 commit into
masterfrom
webUIExternal-no-skeleton

Conversation

@paurakhsharma

Copy link
Copy Markdown
Contributor

Description

Don't user skeleton files on webUISharingExternal

Related Issue

owncloud/QA#622

Motivation and Context

  • Make CI faster in scenarios where there is no need for user files.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Jun 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35534 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35534      +/-   ##
============================================
- Coverage     65.68%   65.37%   -0.32%     
  Complexity    18735    18735              
============================================
  Files          1221     1221              
  Lines         70793    70759      -34     
  Branches       1288     1288              
============================================
- Hits          46503    46258     -245     
- Misses        23913    24124     +211     
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.71% <ø> (-0.36%) 18735 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...ivate/Files/ObjectStore/HomeObjectStoreStorage.php 0% <0%> (-86.67%) 8% <0%> (ø)
lib/private/Files/Storage/Wrapper/Availability.php 10.38% <0%> (-38.97%) 80% <0%> (ø)
lib/private/Files/ObjectStore/NoopScanner.php 68.75% <0%> (-18.75%) 6% <0%> (ø)
lib/private/Share/Share.php 27.04% <0%> (-16.33%) 70% <0%> (ø)
...b/private/Files/ObjectStore/ObjectStoreStorage.php 70.97% <0%> (-14.34%) 102% <0%> (ø)
lib/private/Preview/MP3.php 45.16% <0%> (-12.91%) 13% <0%> (ø)
lib/private/Autoloader.php 80.48% <0%> (-12.2%) 20% <0%> (ø)
apps/files_sharing/lib/Scanner.php 85.71% <0%> (-9.53%) 7% <0%> (ø)
lib/private/App/Platform.php 29.16% <0%> (-8.34%) 11% <0%> (ø)
lib/private/Files/Cache/Storage.php 75.86% <0%> (-4.6%) 32% <0%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3663703...b119b83. Read the comment docs.

@codecov

codecov Bot commented Jun 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35534 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35534      +/-   ##
============================================
- Coverage     65.66%   65.62%   -0.05%     
- Complexity    18756    18835      +79     
============================================
  Files          1222     1222              
  Lines         70872    71329     +457     
  Branches       1289     1320      +31     
============================================
+ Hits          46540    46808     +268     
- Misses        23954    24150     +196     
+ Partials        378      371       -7
Flag Coverage Δ Complexity Δ
#javascript 54.23% <ø> (+0.53%) 0 <ø> (ø) ⬇️
#phpunit 66.93% <ø> (-0.11%) 18835 <ø> (+79)
Impacted Files Coverage Δ Complexity Δ
apps/federatedfilesharing/lib/Notifications.php 37.13% <0%> (-4.65%) 59% <0%> (+14%)
...ederatedfilesharing/lib/FederatedShareProvider.php 61.37% <0%> (-1.32%) 121% <0%> (+34%)
lib/private/Repair.php 80.95% <0%> (-0.57%) 30% <0%> (+9%)
console.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
lib/private/Console/Application.php 0% <0%> (ø) 45% <0%> (+22%) ⬆️
core/js/sharedialogview.js 84.48% <0%> (+5.87%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59ec86...fa6d687. Read the comment docs.

@phil-davis

Copy link
Copy Markdown
Contributor

https://drone.owncloud.com/owncloud/core/18367/784

--- Failed scenarios:

    /drone/src/tests/acceptance/features/webUISharingExternal/federationSharing.feature:288

1 scenario (1 failed)
29 steps (25 passed, 1 failed, 3 skipped)
1m17.91s (22.25Mb)
webUI test rerun failed with exit status: 1

some problem with which users now receive a share and end up with (2) on the end of the name.

I restarted the drone build, just to confirm if the same problem happens again.

@paurakhsharma

Copy link
Copy Markdown
Contributor Author

Backport on: #35553

@DeepDiver1975
DeepDiver1975 merged commit 3ddb3bc into master Jun 17, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the webUIExternal-no-skeleton branch June 17, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants