webui sharing public without skeleton - #35535
Merged
DeepDiver1975 merged 1 commit intoJun 18, 2019
Merged
Conversation
haribhandari07
requested review from
dpakach and
phil-davis
and removed request for
phil-davis
June 14, 2019 10:59
dpakach
reviewed
Jun 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #35535 +/- ##
=========================================
Coverage 65.68% 65.68%
Complexity 18735 18735
=========================================
Files 1221 1221
Lines 70793 70793
Branches 1288 1288
=========================================
Hits 46503 46503
Misses 23913 23913
Partials 377 377
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35535 +/- ##
=========================================
Coverage 65.66% 65.66%
Complexity 18756 18756
=========================================
Files 1222 1222
Lines 70872 70872
Branches 1289 1289
=========================================
Hits 46540 46540
Misses 23954 23954
Partials 378 378
Continue to review full report at Codecov.
|
19 tasks
phil-davis
approved these changes
Jun 17, 2019
Contributor
|
@haribhandari07 there are conflicts. Please rebase, resolve and push. |
Member
|
conflicting |
Contributor
Author
|
Backport on #35572 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not use skeleton files for
webUISharingPublicto speed up CIRelated Issue
Part of owncloud/QA#622
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: