Skip to content

webui sharing public without skeleton - #35535

Merged
DeepDiver1975 merged 1 commit into
owncloud:masterfrom
haribhandari07:webui-sharing-public
Jun 18, 2019
Merged

webui sharing public without skeleton#35535
DeepDiver1975 merged 1 commit into
owncloud:masterfrom
haribhandari07:webui-sharing-public

Conversation

@haribhandari07

Copy link
Copy Markdown
Contributor

Description

Do not use skeleton files for webUISharingPublic to speed up CI

Related Issue

Part of owncloud/QA#622

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov

codecov Bot commented Jun 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35535 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35535   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18735    18735           
=========================================
  Files          1221     1221           
  Lines         70793    70793           
  Branches       1288     1288           
=========================================
  Hits          46503    46503           
  Misses        23913    23913           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.06% <ø> (ø) 18735 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3663703...1951546. Read the comment docs.

@codecov

codecov Bot commented Jun 14, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35535 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35535   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18756    18756           
=========================================
  Files          1222     1222           
  Lines         70872    70872           
  Branches       1289     1289           
=========================================
  Hits          46540    46540           
  Misses        23954    23954           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.03% <ø> (ø) 18756 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ddb3bc...27525d5. Read the comment docs.

@dpakach dpakach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis

Copy link
Copy Markdown
Contributor

@haribhandari07 there are conflicts. Please rebase, resolve and push.

@DeepDiver1975

Copy link
Copy Markdown
Member

conflicting

@haribhandari07

Copy link
Copy Markdown
Contributor Author

Backport on #35572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants