Skip to content

webdav lock protection without skeleton - #35557

Merged
phil-davis merged 1 commit into
masterfrom
skeleton-webdav-lock-protection
Jun 18, 2019
Merged

webdav lock protection without skeleton#35557
phil-davis merged 1 commit into
masterfrom
skeleton-webdav-lock-protection

Conversation

@haribhandari07

Copy link
Copy Markdown
Contributor

Description

Do not use skeleton files for webUIWebdavLockProtection to speed up CI

Related Issue

Part of owncloud/QA#622

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov

codecov Bot commented Jun 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35557 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35557      +/-   ##
============================================
- Coverage     65.66%   65.66%   -0.01%     
+ Complexity    18757    18756       -1     
============================================
  Files          1222     1222              
  Lines         70873    70872       -1     
  Branches       1289     1289              
============================================
- Hits          46541    46540       -1     
  Misses        23954    23954              
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.03% <ø> (-0.01%) 18756 <ø> (-1)
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php 87.36% <0%> (-0.03%) 208% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78421c7...441893c. Read the comment docs.

@codecov

codecov Bot commented Jun 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35557 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35557   +/-   ##
=========================================
  Coverage     65.66%   65.66%           
  Complexity    18757    18757           
=========================================
  Files          1222     1222           
  Lines         70873    70873           
  Branches       1289     1289           
=========================================
  Hits          46541    46541           
  Misses        23954    23954           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.03% <ø> (ø) 18757 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8502a92...92ceb2e. Read the comment docs.

Comment thread tests/acceptance/features/webUIWebdavLockProtection/move.feature Outdated
@haribhandari07
haribhandari07 requested a review from dpakach June 18, 2019 05:22
@haribhandari07
haribhandari07 force-pushed the skeleton-webdav-lock-protection branch from 441893c to 92ceb2e Compare June 18, 2019 06:02

@dpakach dpakach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@paurakhsharma paurakhsharma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@haribhandari07

Copy link
Copy Markdown
Contributor Author

Backport on #35574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants