Skip to content

Test that an emoji works in the user full name via API - #35576

Merged
patrickjahns merged 1 commit into
masterfrom
emoji-in-user-full-name
Jun 18, 2019
Merged

Test that an emoji works in the user full name via API#35576
patrickjahns merged 1 commit into
masterfrom
emoji-in-user-full-name

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

Test setting the user display name (full name) including an emoji via the Provisioning API.

(I was looking around these files anyway and noticed that this test scenario was still to-do in the issue)

Note: these emoji tests are mostly being done using the AP for now. The webUI chromedriver does not like typing emojis, so more effort is needed to try and work-around that.

Related Issue

#34437

How Has This Been Tested?

Local run of test scenario.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Examples:
| display-name |
| Alan Border |
| Phil Cyclist 🚴 |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis

Copy link
Copy Markdown
Contributor Author

Backport stable10 #35578

@patrickjahns
patrickjahns merged commit a8a7b91 into master Jun 18, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the emoji-in-user-full-name branch June 18, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants