Use full skeleton for webUI browseDirectlyToDetailsTab.feature#35588
Merged
Conversation
phil-davis
requested review from
dpakach,
haribhandari07,
paurakhsharma and
skshetry
Contributor
Author
|
I noticed this when backporting test code for |
Contributor
Author
|
Backport |
skshetry
approved these changes
Jun 19, 2019
Contributor
Author
|
So sad, codecov result did not come. |
paurakhsharma
approved these changes
Jun 19, 2019
delete-merged-branch
Bot
deleted the
skeleton-for-browseDirectlyToDetailsTab
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When doing "Speed up CI" changes,
browseDirectlyToDetailsTab.featurewas adjusted to not use the full skeleton. But there are test scenarios that want to check what happens when there is a long list of files to be displayed, and we want to browse directly to a file down the end of the list. For these scenarios to be realistic, they need to have a longer list of files.Put back the full skeleton.
Related Issue
owncloud/QA#621
Motivation and Context
Make sure test scenarios are effective.
How Has This Been Tested?
#35283 fixed a bug in
browseDirectlyToDetailsTab.To test the effectiveness of the test scenarios:
apps/files/js/filelist.jsbrowseDirectlyToDetailsTab.feature- it still all passes :(browseDirectlyToDetailsTab.feature- there are some test fails :) so the tests are now effectiveapps/files/js/filelist.jsbrowseDirectlyToDetailsTab.feature- it passes :) - the code change makes the tests passTypes of changes
Checklist:
Open tasks: