Skip failing tests in files_primary_s3 - #35617
Merged
Merged
Conversation
dpakach
requested review from
individual-it,
paurakhsharma,
phil-davis and
skshetry
June 21, 2019 07:14
individual-it
approved these changes
Jun 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #35617 +/- ##
=========================================
Coverage 65.68% 65.68%
Complexity 18775 18775
=========================================
Files 1222 1222
Lines 70932 70932
Branches 1289 1289
=========================================
Hits 46594 46594
Misses 23960 23960
Partials 378 378
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #35617 +/- ##
=========================================
Coverage 65.68% 65.68%
Complexity 18775 18775
=========================================
Files 1222 1222
Lines 70932 70932
Branches 1289 1289
=========================================
Hits 46594 46594
Misses 23960 23960
Partials 378 378
Continue to review full report at Codecov.
|
Contributor
Author
|
Backport #35619 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After owncloud/files_primary_s3#128 got fixed some core tests that were skipped in
files_primary_s3were unskipped. But the fix have raised another issue (owncloud/files_primary_s3#224). so the tests need to be skipped again.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: