Skip to content

[stable10] if user has enough permission, allow to increase permission - #35634

Merged
phil-davis merged 1 commit into
stable10from
stable10-fix-35528
Jun 25, 2019
Merged

[stable10] if user has enough permission, allow to increase permission#35634
phil-davis merged 1 commit into
stable10from
stable10-fix-35528

Conversation

@patrickjahns

Copy link
Copy Markdown
Contributor

Description

Backport of #35614

Related Issue

#35528

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

Comment thread apps/files_sharing/tests/Controller/Share20OcsControllerTest.php Outdated
Signed-off-by: Patrick Jahns <github@patrickjahns.de>
@codecov

codecov Bot commented Jun 24, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35634 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35634      +/-   ##
==============================================
+ Coverage       64.83%   64.83%   +<.01%     
- Complexity      20223    20225       +2     
==============================================
  Files            1294     1294              
  Lines           77312    77315       +3     
  Branches         1301     1301              
==============================================
+ Hits            50123    50126       +3     
  Misses          26804    26804              
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.99% <100%> (ø) 20225 <6> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php 87.58% <100%> (+0.06%) 213 <6> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173dd4c...470d1d7. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jun 24, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35634 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35634      +/-   ##
==============================================
+ Coverage       64.83%   64.83%   +<.01%     
- Complexity      20223    20225       +2     
==============================================
  Files            1294     1294              
  Lines           77312    77315       +3     
  Branches         1301     1301              
==============================================
+ Hits            50123    50126       +3     
  Misses          26804    26804              
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.99% <100%> (ø) 20225 <6> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php 87.58% <100%> (+0.06%) 213 <6> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173dd4c...470d1d7. Read the comment docs.

@phil-davis
phil-davis merged commit 0979686 into stable10 Jun 25, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the stable10-fix-35528 branch June 25, 2019 04:31
@phil-davis

Copy link
Copy Markdown
Contributor

Note: PR for release-10.2.1 is #35633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants