[stable10] if user has enough permission, allow to increase permission - #35634
Merged
Conversation
patrickjahns
requested review from
DeepDiver1975,
IljaN,
karakayasemi and
micbar
June 24, 2019 10:24
karakayasemi
approved these changes
Jun 24, 2019
phil-davis
reviewed
Jun 24, 2019
Signed-off-by: Patrick Jahns <github@patrickjahns.de>
patrickjahns
force-pushed
the
stable10-fix-35528
branch
from
June 24, 2019 11:22
237b125 to
470d1d7
Compare
Codecov Report
@@ Coverage Diff @@
## stable10 #35634 +/- ##
==============================================
+ Coverage 64.83% 64.83% +<.01%
- Complexity 20223 20225 +2
==============================================
Files 1294 1294
Lines 77312 77315 +3
Branches 1301 1301
==============================================
+ Hits 50123 50126 +3
Misses 26804 26804
Partials 385 385
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable10 #35634 +/- ##
==============================================
+ Coverage 64.83% 64.83% +<.01%
- Complexity 20223 20225 +2
==============================================
Files 1294 1294
Lines 77312 77315 +3
Branches 1301 1301
==============================================
+ Hits 50123 50126 +3
Misses 26804 26804
Partials 385 385
Continue to review full report at Codecov.
|
11 tasks
phil-davis
approved these changes
Jun 25, 2019
Contributor
|
Note: PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #35614
Related Issue
#35528
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: