Enhance createShare.feature test scenarios

[phil-davis]

Description

1. Add test methods to check things that "the public" should not be able to do.
2. Add some extra text to existing createShare.feature scenario outlines to describe what permissions they are testing
3. Add some detailed the fields of the last response should include checks to validate the detail of fields in responses.
4. Add some "negative" checks to verify that only the correct password works.

The 2nd commit adjusts various sharing tests so that either they have users and groups that are available on LDAP, or skip them on LDAP. That should get user_ldap CI passing.

Related Issue

owncloud/user_ldap#429 - debug failing tests in user_ldap
owncloud/user_ldap#250 - discussion on future sorting out of this dependency between core acceptance test scenarios and user_ldap testing.

Motivation and Context

Test sharing in more detail.

How Has This Been Tested?

Local acceptance test runs

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[codecov]

Codecov Report

Merging #35638 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #35638      +/-   ##
============================================
- Coverage     65.68%   65.68%   -0.01%     
+ Complexity    18777    18775       -2     
============================================
  Files          1222     1222              
  Lines         70935    70932       -3     
  Branches       1289     1289              
============================================
- Hits          46597    46594       -3     
  Misses        23960    23960              
  Partials        378      378

Flag	Coverage Δ	Complexity Δ
#javascript	53.7% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	67.05% <ø> (-0.01%)	18775 <ø> (-2)

Impacted Files	Coverage Δ	Complexity Δ
...es_sharing/lib/Controller/Share20OcsController.php	87.5% <0%> (-0.07%)	211% <0%> (-2%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d356f5...67448b1. Read the comment docs.

[codecov]

Codecov Report

Merging #35638 into master will increase coverage by 16.68%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #35638       +/-   ##
=============================================
+ Coverage     49.09%   65.77%   +16.68%     
- Complexity        0    18781    +18781     
=============================================
  Files           109     1222     +1113     
  Lines         10535    70870    +60335     
  Branches       1289     1289               
=============================================
+ Hits           5172    46618    +41446     
- Misses         4985    23874    +18889     
  Partials        378      378

Flag	Coverage Δ	Complexity Δ
#javascript	53.7% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	67.16% <ø> (+28.37%)	18781 <ø> (+18781)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
apps/updatenotification/templates/admin.php	0% <0%> (ø)	0% <0%> (?)
lib/private/Encryption/Keys/Storage.php	88.03% <0%> (ø)	48% <0%> (?)
lib/private/App/CodeChecker/NodeVisitor.php	95.86% <0%> (ø)	54% <0%> (?)
lib/private/RedisFactory.php	0% <0%> (ø)	19% <0%> (?)
apps/dav/lib/Avatars/AvatarNode.php	72% <0%> (ø)	9% <0%> (?)
...s/dav/appinfo/Migrations/Version20170202213905.php	21.05% <0%> (ø)	12% <0%> (?)
apps/dav/lib/Upload/ChunkLocationProvider.php	100% <0%> (ø)	4% <0%> (?)
apps/files/lib/AppInfo/Application.php	40.47% <0%> (ø)	7% <0%> (?)
apps/systemtags/list.php	0% <0%> (ø)	0% <0%> (?)
lib/private/Session/CryptoSessionData.php	84% <0%> (ø)	19% <0%> (?)
... and 1104 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdfd389...7dc3d92. Read the comment docs.

[phil-davis]

This is now covered in the scenario at line 208

[phil-davis]

Backport stable10 #35686