Skip to content

sharing with user and groups with different case username and groupname using api#35647

Merged
phil-davis merged 1 commit into
masterfrom
api-share-user-group-case-not-sensitive
Jun 26, 2019
Merged

sharing with user and groups with different case username and groupname using api#35647
phil-davis merged 1 commit into
masterfrom
api-share-user-group-case-not-sensitive

Conversation

@haribhandari07

Copy link
Copy Markdown
Contributor

Description

Add api tests to:

  • share with users and using different case of the username

  • share with groups using different case of the group name

Related Issue

Part of #35354

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Comment thread tests/acceptance/features/apiShareManagementBasic/createShare.feature Outdated
@codecov

codecov Bot commented Jun 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35647 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35647   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18777    18777           
=========================================
  Files          1222     1222           
  Lines         70935    70935           
  Branches       1289     1289           
=========================================
  Hits          46597    46597           
  Misses        23960    23960           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.06% <ø> (ø) 18777 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d356f5...5b6d268. Read the comment docs.

@codecov

codecov Bot commented Jun 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35647 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35647   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18777    18777           
=========================================
  Files          1222     1222           
  Lines         70935    70935           
  Branches       1289     1289           
=========================================
  Hits          46596    46596           
  Misses        23961    23961           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.05% <ø> (ø) 18777 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22ef0f...0752a90. Read the comment docs.

@micbar micbar added this to the development milestone Jun 25, 2019
@haribhandari07
haribhandari07 force-pushed the api-share-user-group-case-not-sensitive branch 3 times, most recently from b3e979d to 9e9dd11 Compare June 26, 2019 03:23

@paurakhsharma paurakhsharma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis

Copy link
Copy Markdown
Contributor

@haribhandari07 please:

  • rebase this PR. Current master should pass much better.
  • make backport to stable10

@haribhandari07

Copy link
Copy Markdown
Contributor Author

Backport on #35675

@phil-davis
phil-davis merged commit 08241b6 into master Jun 26, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the api-share-user-group-case-not-sensitive branch June 26, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants