sharing with user and groups with different case username and groupname using api#35647
Merged
Merged
Conversation
13 tasks
skshetry
reviewed
Jun 25, 2019
skshetry
reviewed
Jun 25, 2019
skshetry
reviewed
Jun 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #35647 +/- ##
=========================================
Coverage 65.68% 65.68%
Complexity 18777 18777
=========================================
Files 1222 1222
Lines 70935 70935
Branches 1289 1289
=========================================
Hits 46597 46597
Misses 23960 23960
Partials 378 378
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35647 +/- ##
=========================================
Coverage 65.68% 65.68%
Complexity 18777 18777
=========================================
Files 1222 1222
Lines 70935 70935
Branches 1289 1289
=========================================
Hits 46596 46596
Misses 23961 23961
Partials 378 378
Continue to review full report at Codecov.
|
haribhandari07
force-pushed
the
api-share-user-group-case-not-sensitive
branch
3 times, most recently
from
June 26, 2019 03:23
b3e979d to
9e9dd11
Compare
paurakhsharma
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me 👍
phil-davis
approved these changes
Jun 26, 2019
Contributor
|
@haribhandari07 please:
|
haribhandari07
force-pushed
the
api-share-user-group-case-not-sensitive
branch
from
June 26, 2019 10:30
9e9dd11 to
0752a90
Compare
Contributor
Author
|
Backport on #35675 |
delete-merged-branch
Bot
deleted the
api-share-user-group-case-not-sensitive
branch
June 26, 2019 13:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add api tests to:
share with users and using different case of the username
share with groups using different case of the group name
Related Issue
Part of #35354
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: