Make consistent file-folder-entry test steps

[phil-davis]

Description

Make all acceptance test steps that talk about file "some-file-or-folder" be able to also say folder "some-file-or-folder" where the step can just-as-well work with a folder.

Adjust existing test scenarios in feature files so that they say folder when the item-in-question is a folder.

I noticed this while making new sharing API acceptance tests. But it will be easier to do the refactoring in this separate PR, then make use of it anywhere.

Motivation and Context

Some acceptance test steps have been written like:

When user "user0" shares file "/test/sub" with user "user1" using the sharing API

and actually it is a folder that is being shared.

It works fine, but makes people reading it wonder if something is wrong.

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[phil-davis]

Backport stable10 #35657

[codecov]

Codecov Report

Merging #35656 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #35656   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18777    18777           
=========================================
  Files          1222     1222           
  Lines         70935    70935           
  Branches       1289     1289           
=========================================
  Hits          46597    46597           
  Misses        23960    23960           
  Partials        378      378

Flag	Coverage Δ	Complexity Δ
#javascript	53.7% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	67.06% <ø> (ø)	18777 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d356f5...5c252d2. Read the comment docs.

[codecov]

Codecov Report

Merging #35656 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #35656      +/-   ##
============================================
- Coverage     65.68%   65.68%   -0.01%     
  Complexity    18777    18777              
============================================
  Files          1222     1222              
  Lines         70935    70935              
  Branches       1289     1289              
============================================
- Hits          46596    46593       -3     
- Misses        23961    23964       +3     
  Partials        378      378

Flag	Coverage Δ	Complexity Δ
#javascript	53.7% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	67.05% <ø> (-0.01%)	18777 <ø> (ø)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/DB/Connection.php	66.91% <0%> (-0.74%)	49% <0%> (ø)
lib/private/Files/View.php	84.3% <0%> (-0.31%)	398% <0%> (ø)
apps/files_trashbin/lib/Expiration.php	98.27% <0%> (+1.72%)	29% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22ef0f...d8479d7. Read the comment docs.

[phil-davis]

Rebased to get fresh CI. Can merge of it goes green.

[phil-davis]

No codecov result.
@micbar @DeepDiver1975 @patrickjahns or anyone - please merge.