Skip to content

[stable10] Fix drone webUIMasterKeyType so it runs the tests#35659

Merged
phil-davis merged 1 commit into
stable10from
stable10-fix-drone-webUIMasterKeyType
Jun 26, 2019
Merged

[stable10] Fix drone webUIMasterKeyType so it runs the tests#35659
phil-davis merged 1 commit into
stable10from
stable10-fix-drone-webUIMasterKeyType

Conversation

@phil-davis

@phil-davis phil-davis commented Jun 25, 2019

Copy link
Copy Markdown
Contributor

Description

I noticed that the last job in drone, webUIMasterKeyType, ran and exited with success but never actually executed the expected acceptance tests

Somewhere in backports or... the line:

      TEST_SUITE: webui

is now:

      TEST_SUITE: selenium

and that did not get updated for the sstable10-only webUIMasterKeyType encryption suite.

  1. fixup the drone job parameters for webUIMasterKeyType
  2. move the other encryption suite webUIUserKeysType down the end also, so they are close together (easier to find)
  3. comment all the encryption suites with "This suite is part of the encryption app in later core versions" (consistent with the way it has been done for the user_management app)

Note: this is stable10 only. encryption is in a separate repo for core master. So no forward-back-port needed.

Motivation and Context

Actually run tests in CI ;)

How Has This Been Tested?

Observe the run of CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis

Copy link
Copy Markdown
Contributor Author

https://drone.owncloud.com/owncloud/core/18826/1105

2 scenarios (2 passed)
19 steps (19 passed)
6m22.96s (21.19Mb)

@individual-it

Copy link
Copy Markdown
Member

Don't we need?

CONFIGURE_ENCRYPTION: true
ENCRYPTION_TYPE: masterkey

@phil-davis

Copy link
Copy Markdown
Contributor Author

Don't we need?

CONFIGURE_ENCRYPTION: true
ENCRYPTION_TYPE: masterkey

That is already in the job parameters, further down.

Comment thread .drone.yml
- PHP_VERSION: 7.1
TEST_SUITE: selenium
BROWSER: chrome
BEHAT_SUITE: webUIUserKeysType

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: webUIUserKeysType runs fine without setting CONFIGURE_ENCRYPTION or ENCRYPTION_TYPE
The feature file sets up the encryption type etc.

@phil-davis phil-davis force-pushed the stable10-fix-drone-webUIMasterKeyType branch 2 times, most recently from 5e318e4 to 7a4e050 Compare June 25, 2019 16:12
@codecov

codecov Bot commented Jun 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35659 into stable10 will decrease coverage by 18.49%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35659      +/-   ##
==============================================
- Coverage       64.02%   45.52%   -18.5%     
==============================================
  Files            1294      116    -1178     
  Lines           77280    11554   -65726     
  Branches         1301     1301              
==============================================
- Hits            49475     5260   -44215     
+ Misses          27420     5909   -21511     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 30.81% <ø> (-34.29%) 0 <ø> (-20225)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 59.45% <0%> (-21.64%) 0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1169 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b49720...7a4e050. Read the comment docs.

@codecov

codecov Bot commented Jun 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35659 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35659   +/-   ##
===========================================
  Coverage       64.83%   64.83%           
  Complexity      20225    20225           
===========================================
  Files            1294     1294           
  Lines           77315    77315           
  Branches         1301     1301           
===========================================
  Hits            50126    50126           
  Misses          26804    26804           
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.99% <ø> (ø) 20225 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dd5b2b...da3dd93. Read the comment docs.

@phil-davis phil-davis force-pushed the stable10-fix-drone-webUIMasterKeyType branch from 7a4e050 to aaef8e7 Compare June 25, 2019 16:48
@phil-davis phil-davis force-pushed the stable10-fix-drone-webUIMasterKeyType branch from aaef8e7 to da3dd93 Compare June 26, 2019 08:37
@phil-davis

Copy link
Copy Markdown
Contributor Author

General CI is improved now. I rebased, let's see if we get a good result.

@phil-davis phil-davis merged commit d7bc5f8 into stable10 Jun 26, 2019
@delete-merged-branch delete-merged-branch Bot deleted the stable10-fix-drone-webUIMasterKeyType branch June 26, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants