You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that the last job in drone, webUIMasterKeyType, ran and exited with success but never actually executed the expected acceptance tests
Somewhere in backports or... the line:
TEST_SUITE: webui
is now:
TEST_SUITE: selenium
and that did not get updated for the sstable10-only webUIMasterKeyType encryption suite.
fixup the drone job parameters for webUIMasterKeyType
move the other encryption suite webUIUserKeysType down the end also, so they are close together (easier to find)
comment all the encryption suites with "This suite is part of the encryption app in later core versions" (consistent with the way it has been done for the user_management app)
Note: this is stable10 only. encryption is in a separate repo for core master. So no forward-back-port needed.
Motivation and Context
Actually run tests in CI ;)
How Has This Been Tested?
Observe the run of CI
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the last job in drone,
webUIMasterKeyType, ran and exited with success but never actually executed the expected acceptance testsSomewhere in backports or... the line:
is now:
and that did not get updated for the sstable10-only
webUIMasterKeyTypeencryption suite.webUIMasterKeyTypewebUIUserKeysTypedown the end also, so they are close together (easier to find)user_managementapp)Note: this is
stable10only.encryptionis in a separate repo for coremaster. So no forward-back-port needed.Motivation and Context
Actually run tests in CI ;)
How Has This Been Tested?
Observe the run of CI
Types of changes
Checklist: