Skip to content

[stable10] Add Better error handling to batch user create function in acceptance tests#35674

Merged
phil-davis merged 1 commit into
stable10from
stable10-error-handle-create-users
Jun 26, 2019
Merged

[stable10] Add Better error handling to batch user create function in acceptance tests#35674
phil-davis merged 1 commit into
stable10from
stable10-error-handle-create-users

Conversation

@dpakach

@dpakach dpakach commented Jun 26, 2019

Copy link
Copy Markdown
Contributor

Backport for #35672

@skshetry skshetry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis changed the title Add Better error handling to batch user create function in acceptance tests [stable10] Add Better error handling to batch user create function in acceptance tests Jun 26, 2019
@codecov

codecov Bot commented Jun 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35674 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35674   +/-   ##
===========================================
  Coverage       64.82%   64.82%           
  Complexity      20225    20225           
===========================================
  Files            1294     1294           
  Lines           77315    77315           
  Branches         1301     1301           
===========================================
  Hits            50119    50119           
  Misses          26811    26811           
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.98% <ø> (ø) 20225 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bc5f8...aa36081. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jun 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35674 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35674   +/-   ##
===========================================
  Coverage       64.82%   64.82%           
  Complexity      20225    20225           
===========================================
  Files            1294     1294           
  Lines           77315    77315           
  Branches         1301     1301           
===========================================
  Hits            50119    50119           
  Misses          26811    26811           
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.98% <ø> (ø) 20225 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bc5f8...aa36081. Read the comment docs.

@phil-davis
phil-davis merged commit b6cae3e into stable10 Jun 26, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the stable10-error-handle-create-users branch June 26, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants