Skip to content

[stable10] Test regression with public link not created when default expiration date set and enforced#35703

Merged
skshetry merged 2 commits into
stable10from
stable10-regression-35550
Jul 1, 2019
Merged

[stable10] Test regression with public link not created when default expiration date set and enforced#35703
skshetry merged 2 commits into
stable10from
stable10-regression-35550

Conversation

@skshetry

@skshetry skshetry commented Jul 1, 2019

Copy link
Copy Markdown
Contributor

Backport for #35594

Description

This adds a regression test that public link was not getting created when default expiration date was set and enforced. This also tests the functionality of #34960.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov

codecov Bot commented Jul 1, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35703 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35703   +/-   ##
===========================================
  Coverage       64.86%   64.86%           
  Complexity      20225    20225           
===========================================
  Files            1294     1294           
  Lines           77279    77279           
  Branches         1301     1301           
===========================================
  Hits            50126    50126           
  Misses          26768    26768           
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.02% <ø> (ø) 20225 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0084cb...25652a7. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jul 1, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35703 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35703   +/-   ##
===========================================
  Coverage       64.86%   64.86%           
  Complexity      20225    20225           
===========================================
  Files            1294     1294           
  Lines           77279    77279           
  Branches         1301     1301           
===========================================
  Hits            50126    50126           
  Misses          26768    26768           
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.02% <ø> (ø) 20225 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0084cb...25652a7. Read the comment docs.

@skshetry skshetry merged commit 8295f35 into stable10 Jul 1, 2019
@delete-merged-branch delete-merged-branch Bot deleted the stable10-regression-35550 branch July 1, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants