Skip to content

fix phpstan 'Undefined variable: ' reported for togglegroups.php#35769

Merged
phil-davis merged 1 commit into
stable10from
stable10-fix-undefined-var-togglegroups
Jul 5, 2019
Merged

fix phpstan 'Undefined variable: ' reported for togglegroups.php#35769
phil-davis merged 1 commit into
stable10from
stable10-fix-undefined-var-togglegroups

Conversation

@phil-davis

@phil-davis phil-davis commented Jul 5, 2019

Copy link
Copy Markdown
Contributor

Description

I was looking at phpstan in core stable10 and of course it reports lots of things that would be fixed by backport various commits from master #31810

But this one is a problem in user_management code, which is not in core master.

It looks easy to fix, so fix it.

Motivation and Context

Fix random errors.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

@phil-davis

Copy link
Copy Markdown
Contributor Author

The "restore" step hung in drone https://drone.owncloud.com/owncloud/core/19261/232 :(
I restarted the build.

@phil-davis

phil-davis commented Jul 5, 2019

Copy link
Copy Markdown
Contributor Author

Forward port to user_management owncloud-archive/user_management#193

@phil-davis phil-davis force-pushed the stable10-fix-undefined-var-togglegroups branch from 454e3f4 to 11cbc20 Compare July 5, 2019 13:31
@codecov

codecov Bot commented Jul 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35769 into stable10 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35769      +/-   ##
==============================================
- Coverage       64.99%   64.99%   -0.01%     
  Complexity      20279    20279              
==============================================
  Files            1302     1302              
  Lines           77353    77354       +1     
  Branches         1301     1301              
==============================================
  Hits            50274    50274              
- Misses          26694    26695       +1     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.16% <0%> (-0.01%) 20279 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
settings/ajax/togglegroups.php 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97b059...11cbc20. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jul 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #35769 into stable10 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35769      +/-   ##
==============================================
- Coverage       64.99%   64.99%   -0.01%     
  Complexity      20279    20279              
==============================================
  Files            1302     1302              
  Lines           77353    77354       +1     
  Branches         1301     1301              
==============================================
  Hits            50274    50274              
- Misses          26694    26695       +1     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.16% <0%> (-0.01%) 20279 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
settings/ajax/togglegroups.php 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97b059...11cbc20. Read the comment docs.

@phil-davis phil-davis merged commit 45046f3 into stable10 Jul 5, 2019
@delete-merged-branch delete-merged-branch Bot deleted the stable10-fix-undefined-var-togglegroups branch July 5, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants