Skip to content

[stable10] Kill APC and XCache - fixes #28597#35782

Merged
DeepDiver1975 merged 1 commit into
stable10from
stable10-kill-apc-xcache
Jul 8, 2019
Merged

[stable10] Kill APC and XCache - fixes #28597#35782
DeepDiver1975 merged 1 commit into
stable10from
stable10-kill-apc-xcache

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

Backport from #28043 of a596201

This commit is currently sitting waiting in #34936 [stable10] "drop PHP 7.0"
But [stable10] "Introduce phpstan" #35774 is having to specifically exclude APC.php
So it will be easier all-round if we can delete this code now.
IMO it was only waiting for PHP 5.6 to be dropped.

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Jul 8, 2019
@phil-davis phil-davis mentioned this pull request Jul 8, 2019
10 tasks
@phil-davis

Copy link
Copy Markdown
Contributor Author

@DeepDiver1975 Does this seem OK to do now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants