Skip to content

Run all unit tests on PHP 7.0#35959

Closed
phil-davis wants to merge 1 commit into
masterfrom
run-all-unit-tests-on-php-70
Closed

Run all unit tests on PHP 7.0#35959
phil-davis wants to merge 1 commit into
masterfrom
run-all-unit-tests-on-php-70

Conversation

@phil-davis

@phil-davis phil-davis commented Jul 31, 2019

Copy link
Copy Markdown
Contributor

Description

tests/drone/test-phpunit.sh has logic that only runs all the unit tests if the database is sqlite or coverage is requested. Otherwise it sets --group DB and only about half the unit tests are run.

For PHP 7.0 there is not currently a drone matrix entry that has sqlite. So we are not getting the full set of unit tests run on PHP 7.0

This draft PR adds the needed matrix entry.

Probably the unit test run will fail because of the PHP 7.1-only code that exists (see PR #35958 ). So after demonstrating here, I will add this commit to that PR.

Motivation and Context

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis

Copy link
Copy Markdown
Contributor Author

As expected, that new sqlite DB with PHP 7.0 unit test job fails
https://drone.owncloud.com/owncloud/core/19859/193

I have added this commit to PR #35958

@phil-davis phil-davis closed this Jul 31, 2019
@phil-davis phil-davis deleted the run-all-unit-tests-on-php-70 branch July 31, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant