Php7.4 20200101

[phil-davis]

Try running tests with PHP 7.4

[codecov]

Codecov Report

Merging #36670 into master will increase coverage by 19.1%.
The diff coverage is 20%.

@@             Coverage Diff              @@
##             master   #36670      +/-   ##
============================================
+ Coverage     46.74%   65.84%   +19.1%     
- Complexity        0    19283   +19283     
============================================
  Files           111     1222    +1111     
  Lines         10891    71775   +60884     
  Branches       1327     1320       -7     
============================================
+ Hits           5091    47262   +42171     
- Misses         5409    24125   +18716     
+ Partials        391      388       -3

Flag	Coverage Δ	Complexity Δ
#javascript	54.12% <ø> (+0.02%)	0 <ø> (ø)	⬇️
#phpunit	67.2% <20%> (+36.64%)	19283 <0> (+19283)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Cache/Cache.php	97.57% <ø> (ø)	104 <0> (?)
index.php	0% <0%> (ø)	0 <0> (?)
console.php	0% <0%> (ø)	0 <0> (?)
...AppFramework/Utility/ControllerMethodReflector.php	100% <100%> (ø)	10 <0> (?)
core/js/shareitemmodel.js	80.31% <0%> (ø)	0% <0%> (ø)	⬇️
apps/files_external/lib/Command/Backends.php
apps/files_external/lib/Lib/Backend/SFTP_Key.php
apps/files_external/ajax/applicable.php
apps/files_external/lib/Lib/Api.php
apps/files_external/lib/Lib/Backend/DAV.php
... and 1204 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffabfc6...efa5c45. Read the comment docs.

[phil-davis]

jankaritech/id3parser dev-master fixes the PHP 7.4 deprecation warnings for the old {} array syntax - good. Hopefully that will be fixed soon in ChristophWurst/ID3Parser so that we can switch to that, or...

[phil-davis]

drone is not starting - I might have to make a new PR

[phil-davis]

See #36855
(hmmm - I really just needed to drone starlark --source .drone.starlark here, the auto-rebase had messed up a couple of lines)