[WIP] Guzzle6 for core#37011
Closed
phil-davis wants to merge 5 commits into
Closed
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Codecov Report
@@ Coverage Diff @@
## master #37011 +/- ##
============================================
- Coverage 64.87% 64.57% -0.31%
+ Complexity 19146 19138 -8
============================================
Files 1269 1267 -2
Lines 74947 74862 -85
Branches 1331 1331
============================================
- Hits 48625 48343 -282
- Misses 25930 26127 +197
Partials 392 392
Continue to review full report at Codecov.
|
3965c8d to
a90bcbf
Compare
54fa6be to
6b4a450
Compare
42aa642 to
7d26257
Compare
32b6abd to
36488da
Compare
8a1f4e4 to
81f0184
Compare
359e1d2 to
52e6134
Compare
52e6134 to
272575c
Compare
Contributor
Author
|
See PR #38266 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests/TestHelpers/Unittests again (they rely on having guzzle6 since the acceptance test code was updated to guzzle6)Related Issue
Motivation and Context
Guzzle5 does not have official support on PHP 7.4 and probably never will have. It is likely that Guzzle5 will work on PHP 7.4 but will emit various warning/notice messages about deprecated code.
So it could be "easier/better" to move to Guzzle6 in ownCloud10.
Note1: if we do this then apps that use Guzzzle5 will also need updating to Guzzle6 and coordinated release of core and app versions etc.
Note2: it seems that we do not have to do this for PHP 7.4
How Has This Been Tested?
CI
Types of changes
Checklist: