Skip to content

[WIP] Guzzle6 for core#37011

Closed
phil-davis wants to merge 5 commits into
masterfrom
guzzle6-20200225
Closed

[WIP] Guzzle6 for core#37011
phil-davis wants to merge 5 commits into
masterfrom
guzzle6-20200225

Conversation

@phil-davis

@phil-davis phil-davis commented Feb 25, 2020

Copy link
Copy Markdown
Contributor

Description

  • update dependency for Guzzle to 6.5
  • get adjusted code from old PR Acceptance Tests for case-sensitive file names #32357
  • do whatever is needed to make it work
  • enable Tests/TestHelpers/Unit tests again (they rely on having guzzle6 since the acceptance test code was updated to guzzle6)

Related Issue

Motivation and Context

Guzzle5 does not have official support on PHP 7.4 and probably never will have. It is likely that Guzzle5 will work on PHP 7.4 but will emit various warning/notice messages about deprecated code.

So it could be "easier/better" to move to Guzzle6 in ownCloud10.

Note1: if we do this then apps that use Guzzzle5 will also need updating to Guzzle6 and coordinated release of core and app versions etc.

Note2: it seems that we do not have to do this for PHP 7.4

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Feb 25, 2020
@update-docs

update-docs Bot commented Feb 25, 2020

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@codecov

codecov Bot commented Feb 25, 2020

Copy link
Copy Markdown

Codecov Report

Merging #37011 into master will decrease coverage by 0.3%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37011      +/-   ##
============================================
- Coverage     64.87%   64.57%   -0.31%     
+ Complexity    19146    19138       -8     
============================================
  Files          1269     1267       -2     
  Lines         74947    74862      -85     
  Branches       1331     1331              
============================================
- Hits          48625    48343     -282     
- Misses        25930    26127     +197     
  Partials        392      392
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.73% <66.66%> (-0.34%) 19138 <1> (-8)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 79.09% <ø> (ø) 0 <0> (ø) ⬇️
lib/private/Http/Client/Response.php 53.84% <100%> (ø) 6 <1> (ø) ⬇️
lib/private/Http/Client/Client.php 83.87% <63.63%> (-2.8%) 22 <0> (+2)
...ivate/Files/ObjectStore/HomeObjectStoreStorage.php 0% <0%> (-86.67%) 8% <0%> (ø)
lib/private/Files/Storage/Wrapper/Availability.php 10.38% <0%> (-40.26%) 80% <0%> (ø)
lib/private/Files/ObjectStore/NoopScanner.php 68.75% <0%> (-18.75%) 6% <0%> (ø)
lib/private/Preview/MP3.php 45.16% <0%> (-12.91%) 13% <0%> (ø)
lib/private/Autoloader.php 80.48% <0%> (-12.2%) 20% <0%> (ø)
...b/private/Files/ObjectStore/ObjectStoreStorage.php 66.2% <0%> (-11.04%) 105% <0%> (ø)
lib/private/App/Platform.php 21.73% <0%> (-8.7%) 9% <0%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ae99c...d99a522. Read the comment docs.

@phil-davis phil-davis force-pushed the guzzle6-20200225 branch 4 times, most recently from 3965c8d to a90bcbf Compare March 4, 2020 12:42
@phil-davis phil-davis force-pushed the guzzle6-20200225 branch 3 times, most recently from 54fa6be to 6b4a450 Compare March 19, 2020 12:17
@phil-davis phil-davis force-pushed the guzzle6-20200225 branch 2 times, most recently from 42aa642 to 7d26257 Compare April 13, 2020 08:43
This was referenced Apr 13, 2020
@phil-davis phil-davis force-pushed the guzzle6-20200225 branch 2 times, most recently from 32b6abd to 36488da Compare April 17, 2020 15:56
@phil-davis phil-davis force-pushed the guzzle6-20200225 branch 4 times, most recently from 8a1f4e4 to 81f0184 Compare April 29, 2020 06:13
@phil-davis phil-davis force-pushed the guzzle6-20200225 branch 2 times, most recently from 359e1d2 to 52e6134 Compare May 12, 2020 03:25
@phil-davis phil-davis mentioned this pull request Jan 4, 2021
16 tasks
@phil-davis

Copy link
Copy Markdown
Contributor Author

See PR #38266

@phil-davis phil-davis closed this Jan 4, 2021
@phil-davis phil-davis deleted the guzzle6-20200225 branch January 4, 2021 08:19
@phil-davis phil-davis mentioned this pull request May 7, 2021
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant