Skip to content

[Tests-Only] skip new preview test scenarios on old ownCloud versions - #37240

Merged
individual-it merged 2 commits into
masterfrom
skip-preview-tests-on-old-versions
Apr 13, 2020
Merged

[Tests-Only] skip new preview test scenarios on old ownCloud versions#37240
individual-it merged 2 commits into
masterfrom
skip-preview-tests-on-old-versions

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

PR #37166 added and enhanced tests of previews. Some of the functionality has been fixed in core master since 10.4.0 was released. So some of these fail on old ownCloud versions.
e.g. https://drone.owncloud.com/owncloud/encryption/1195/73/16

--- Failed scenarios:

    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:29
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:30
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:31
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:32
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:33
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:34
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:35
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:45
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:46
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:47
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:48
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:49
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:50
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:51
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:106
    /var/www/owncloud/testrunner/tests/acceptance/features/apiWebdavPreviews/previews.feature:134

33 scenarios (17 passed, 16 failed)
192 steps (145 passed, 16 failed, 31 skipped)

Skip the scenarios when test against old ownCloud versions.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis

Copy link
Copy Markdown
Contributor Author

I added the commit from #37237 "Update nikic/php-parser (4.3.0 => 4.4.0)" because that is needed so that phpstan will not get confused about wich version of the dependency it has.

@codecov

codecov Bot commented Apr 12, 2020

Copy link
Copy Markdown

Codecov Report

Merging #37240 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37240   +/-   ##
=========================================
  Coverage     64.92%   64.92%           
  Complexity    19148    19148           
=========================================
  Files          1267     1267           
  Lines         74895    74895           
  Branches       1331     1331           
=========================================
  Hits          48626    48626           
  Misses        25877    25877           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 66.12% <ø> (ø) 19148.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bd7d4a...1652238. Read the comment docs.

@individual-it
individual-it merged commit 3cc0161 into master Apr 13, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the skip-preview-tests-on-old-versions branch April 13, 2020 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants