Skip to content

[10.4.1] Update nikic/php-parser (4.3.0 => 4.4.0) - #37242

Merged
phil-davis merged 2 commits into
release-10.4.1from
nikic-php-parser-4.4.0-10.4.1
Apr 13, 2020
Merged

[10.4.1] Update nikic/php-parser (4.3.0 => 4.4.0)#37242
phil-davis merged 2 commits into
release-10.4.1from
nikic-php-parser-4.4.0-10.4.1

Conversation

@phil-davis

@phil-davis phil-davis commented Apr 12, 2020

Copy link
Copy Markdown
Contributor

Description

nikic/php-parser has an update to 4.4.0. It is used in core composer.json but it is also a dependency of phpstan in vendor-bin. Without this PR, core has version 4.3.0 but phpstan auto-loads 4.4.0. Then phpstan gets "confused" somehow and fails. It seems that it PHP is running nikic/php-parser 4.3.0 out of lib/composer but phpstan is trying to call new methods that are in nikic/php-parser 4.4.0

This is a port of #37237 to release-10.4.1 branch. Without this, I think branch will get "silly" fails of phpstan in CI. See example in PR #37244

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov

codecov Bot commented Apr 12, 2020

Copy link
Copy Markdown

Codecov Report

Merging #37242 into release-10.4.1 will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release-10.4.1   #37242   +/-   ##
=================================================
  Coverage             64.87%   64.87%           
  Complexity            19143    19143           
=================================================
  Files                  1268     1268           
  Lines                 74940    74940           
  Branches               1331     1331           
=================================================
  Hits                  48619    48619           
  Misses                25929    25929           
  Partials                392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 66.07% <ø> (ø) 19143.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1fc22e...8ede019. Read the comment docs.

@phil-davis
phil-davis merged commit a554bab into release-10.4.1 Apr 13, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the nikic-php-parser-4.4.0-10.4.1 branch April 13, 2020 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants