[WIP] [Tests-Only] phpunit 8 by phil-davis · Pull Request #37286 · owncloud/core

phil-davis · 2020-04-21T04:56:20Z

This is a working branch to sort out the changes needed for phpunit 8.

It is on top of the phpunit 8 PR that the bot raised - #37282

Bumps [phpunit/phpunit](https://github.com/sebastianbergmann/phpunit) from 7.5.20 to 8.5.4. - [Release notes](https://github.com/sebastianbergmann/phpunit/releases) - [Changelog](https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-8.5.md) - [Commits](sebastianbergmann/phpunit@7.5.20...8.5.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

phil-davis · 2020-04-26T04:17:31Z

See PR #37307 for the bot PR that actually implements phpunit 8

codecov · 2020-04-26T04:23:11Z

Codecov Report

Merging #37286 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37286   +/-   ##
=========================================
  Coverage     64.53%   64.53%           
  Complexity    19166    19166           
=========================================
  Files          1266     1266           
  Lines         74952    74952           
  Branches       1331     1331           
=========================================
  Hits          48372    48372           
  Misses        26188    26188           
  Partials        392      392

Flag	Coverage Δ	Complexity Δ
#javascript	`54.14% <ø> (ø)`	`0.00 <ø> (ø)`
#phpunit	`65.69% <ø> (ø)`	`19166.00 <ø> (ø)`

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/Common.php	`84.70% <ø> (ø)`	`138.00 <0.00> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15df678...eb6f32f. Read the comment docs.

codecov · 2020-04-26T04:25:56Z

Codecov Report

Merging #37286 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37286   +/-   ##
=========================================
  Coverage     64.53%   64.53%           
  Complexity    19166    19166           
=========================================
  Files          1266     1266           
  Lines         74952    74952           
  Branches       1331     1331           
=========================================
  Hits          48372    48372           
  Misses        26188    26188           
  Partials        392      392

Flag	Coverage Δ	Complexity Δ
#javascript	`54.14% <ø> (ø)`	`0.00 <ø> (ø)`
#phpunit	`65.69% <ø> (ø)`	`19166.00 <ø> (ø)`

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/Common.php	`84.70% <ø> (ø)`	`138.00 <0.00> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15df678...eb6f32f. Read the comment docs.

codecov · 2020-04-26T04:28:01Z

Codecov Report

Merging #37286 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37286   +/-   ##
=========================================
  Coverage     64.53%   64.53%           
  Complexity    19166    19166           
=========================================
  Files          1266     1266           
  Lines         74952    74952           
  Branches       1331     1331           
=========================================
  Hits          48372    48372           
  Misses        26188    26188           
  Partials        392      392

Flag	Coverage Δ	Complexity Δ
#javascript	`54.14% <ø> (ø)`	`0.00 <ø> (ø)`
#phpunit	`65.69% <ø> (ø)`	`19166.00 <ø> (ø)`

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/Common.php	`84.70% <ø> (ø)`	`138.00 <0.00> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15df678...eb6f32f. Read the comment docs.

codecov · 2020-04-26T04:29:14Z

Codecov Report

Merging #37286 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #37286   +/-   ##
=========================================
  Coverage     64.53%   64.53%           
  Complexity    19166    19166           
=========================================
  Files          1266     1266           
  Lines         74952    74952           
  Branches       1331     1331           
=========================================
  Hits          48372    48372           
  Misses        26188    26188           
  Partials        392      392

Flag	Coverage Δ	Complexity Δ
#javascript	`54.14% <ø> (ø)`	`0.00 <ø> (ø)`
#phpunit	`65.69% <ø> (ø)`	`19166.00 <ø> (ø)`

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/Common.php	`84.70% <ø> (ø)`	`138.00 <0.00> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15df678...eb6f32f. Read the comment docs.

phil-davis · 2020-04-26T04:31:56Z

works

phil-davis added 2 - Developing dev:phpunit-tests labels Apr 21, 2020

phil-davis self-assigned this Apr 21, 2020

phil-davis force-pushed the wip-phpunit-8 branch from de2948b to 3a35947 Compare April 21, 2020 05:36

phil-davis mentioned this pull request Apr 21, 2020

[Tests-Only] Phpunit8 20200326 #37168

Closed

11 tasks

phil-davis force-pushed the wip-phpunit-8 branch 3 times, most recently from 5b61aaf to 5967523 Compare April 25, 2020 13:20

dependabot-preview Bot and others added 6 commits April 26, 2020 09:14

Remove acceptance testing

8bcedf3

Provide a default constructor for OC\Files\Storage\Common

a37bf24

Ignore /tests/.phpunit.result.cache

d0e5940

Adjust getting protected object properties in unit tests

ab4b403

Run all PHP and databases unit test combinations

c88d363

phil-davis force-pushed the wip-phpunit-8 branch from bb0bbd4 to c88d363 Compare April 26, 2020 03:30

Use assertStringContainsString in files_external unit tests

eb6f32f

phil-davis closed this Apr 26, 2020

phil-davis deleted the wip-phpunit-8 branch June 18, 2020 03:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] [Tests-Only] phpunit 8#37286

[WIP] [Tests-Only] phpunit 8#37286
phil-davis wants to merge 7 commits into
masterfrom
wip-phpunit-8

phil-davis commented Apr 21, 2020 •

edited

Loading

Uh oh!

phil-davis commented Apr 26, 2020

Uh oh!

codecov Bot commented Apr 26, 2020

Uh oh!

codecov Bot commented Apr 26, 2020

Uh oh!

codecov Bot commented Apr 26, 2020

Uh oh!

codecov Bot commented Apr 26, 2020

Uh oh!

phil-davis commented Apr 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

phil-davis commented Apr 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phil-davis commented Apr 26, 2020

Uh oh!

codecov Bot commented Apr 26, 2020

Codecov Report

Uh oh!

codecov Bot commented Apr 26, 2020

Codecov Report

Uh oh!

codecov Bot commented Apr 26, 2020

Codecov Report

Uh oh!

codecov Bot commented Apr 26, 2020

Codecov Report

Uh oh!

phil-davis commented Apr 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

phil-davis commented Apr 21, 2020 •

edited

Loading