Skip to content

Bump doctrine/dbal (2.10.4 => 2.13.1)#38604

Closed
phil-davis wants to merge 1 commit into
masterfrom
dbal-2.13.0
Closed

Bump doctrine/dbal (2.10.4 => 2.13.1)#38604
phil-davis wants to merge 1 commit into
masterfrom
dbal-2.13.0

Conversation

@phil-davis

@phil-davis phil-davis commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

Description

https://github.com/doctrine/dbal/releases/tag/2.13.0

doctrine/dbal 2.11 and 2.12 only supported PHP 7.3 and later. So oC10 was not yet able to update to those minor releases (we still support PHP 7.2). Now PHP support in doctrine/dbal has been expanded again in 2.13 so that PHP 7.1 and 7.2 are supported again. This will now let us update right away. That will let us get whatever bug-fixes have happened in 2.11 2.12 and 2.13.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Mar 30, 2021
@phil-davis

Copy link
Copy Markdown
Contributor Author

CI does not manage to install oC10 https://drone.owncloud.com/owncloud/core/29472/4/6

+ php occ maintenance:install -vvv --database=sqlite --database-name=owncloud --database-table-prefix=oc_ --admin-user=admin --admin-pass=admin --data-dir=/drone/src/data
creating sqlite db
Error while trying to create admin user: An exception occurred while executing 'DELETE FROM `*PREFIX*appconfig` WHERE (`appid` = ?) AND (`configkey` = ?)' with params ["core", "shareapi_enforce_links_password"]:

SQLSTATE[HY000]: General error: 1 no such table: *PREFIX*appconfig

The *PREFIX* looks like it is not getting substituted. I guess that there is something different in the doctrine/dbal processing workflow that needs to be adjusted.

@phil-davis

Copy link
Copy Markdown
Contributor Author

I added "doctrine/dbal (2.13.0 => 2.13.1)"

@phil-davis phil-davis changed the title Bump doctrine/dbal (2.10.4 => 2.13.0) Bump doctrine/dbal (2.10.4 => 2.13.1) Apr 22, 2021
@phil-davis

Copy link
Copy Markdown
Contributor Author

See issue #38681 and PRs #38674 and #38647

@phil-davis phil-davis closed this May 3, 2021
@phil-davis
phil-davis deleted the dbal-2.13.0 branch May 3, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant