Skip to content

[tests-only Hardcode PHP unit tests to run on php:7.4-ubuntu20.04#38830

Closed
phil-davis wants to merge 1 commit into
masterfrom
php-ubuntu20.04
Closed

[tests-only Hardcode PHP unit tests to run on php:7.4-ubuntu20.04#38830
phil-davis wants to merge 1 commit into
masterfrom
php-ubuntu20.04

Conversation

@phil-davis

@phil-davis phil-davis commented Jun 10, 2021

Copy link
Copy Markdown
Contributor

Issue #38348

@phil-davis phil-davis self-assigned this Jun 10, 2021
@phil-davis

phil-davis commented Jun 11, 2021

Copy link
Copy Markdown
Contributor Author

https://drone.owncloud.com/owncloud/core/30580/9/8

There were 4 failures:

1) Test\LargeFileHelperGetFileSizeTest::testGetFileSizeViaCurl with data set #0 ('/drone/src/tests/data/lorem.txt', 446)
Failed asserting that null is identical to 446.

/drone/src/tests/lib/LargeFileHelperGetFileSizeTest.php:53

2) Test\LargeFileHelperGetFileSizeTest::testGetFileSizeViaCurl with data set #1 ('/drone/src/tests/data/strängé...2).txt', 446)
Failed asserting that null is identical to 446.

/drone/src/tests/lib/LargeFileHelperGetFileSizeTest.php:53

3) Tests\Core\Templates\TemplatesTest::test403
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 '<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">\n
-<html><body><ul><li class="error">\n
-		Access forbidden<br><p class="hint"></p>\n
-</li></ul></body></html>\n
+<html><body><ul>\n
+<li class="error">\n
+		Access forbidden<br>\n
+		<p class="hint"></p>\n
+	</li>\n
+</ul></body></html>\n
 '

/drone/src/tests/lib/TestCase.php:506
/drone/src/tests/lib/TestCase.php:484
/drone/src/tests/Core/Templates/TemplatesTest.php:9

4) Tests\Core\Templates\TemplatesTest::test404
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 '<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www.w3.org/TR/REC-html40/loose.dtd">\n
-<html><body><ul><li class="error">\n
-			File not found<br><p class="hint">The specified document has not been found on the server.</p>\n
-<p class="hint"><a href="/owncloud/">You can click here to return to ownCloud.</a></p>\n
-		</li></ul></body></html>\n
+<html><body><ul>\n
+<li class="error">\n
+			File not found<br>\n
+			<p class="hint">The specified document has not been found on the server.</p>\n
+			<p class="hint"><a href="/owncloud/">You can click here to return to ownCloud.</a></p>\n
+		</li>\n
+	</ul></body></html>\n
 '

/drone/src/tests/lib/TestCase.php:506
/drone/src/tests/lib/TestCase.php:484
/drone/src/tests/Core/Templates/TemplatesTest.php:16

@phil-davis

phil-davis commented Sep 16, 2021

Copy link
Copy Markdown
Contributor Author

This is something that I still want to look into. We need to get the PHP unit tests passing on Ubuntu 20.04, because that is the "new" long-term-release of Ubuntu.

@phil-davis phil-davis mentioned this pull request Sep 16, 2021
Closed
@phil-davis phil-davis mentioned this pull request Nov 8, 2021
Closed
@phil-davis

phil-davis commented Nov 8, 2021

Copy link
Copy Markdown
Contributor Author

See #39460

@phil-davis phil-davis closed this Nov 8, 2021
@phil-davis
phil-davis deleted the php-ubuntu20.04 branch November 8, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@phil-davis phil-davis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@phil-davis