Skip to content

[tests-only] [full-ci] Add trashbin API tests for deleting files shared with a group#39336

Merged
phil-davis merged 1 commit into
masterfrom
trashbin-group-tests
Oct 19, 2021
Merged

[tests-only] [full-ci] Add trashbin API tests for deleting files shared with a group#39336
phil-davis merged 1 commit into
masterfrom
trashbin-group-tests

Conversation

@phil-davis

@phil-davis phil-davis commented Oct 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add test scenarios to demonstrate the behavior of the trashbin when files or folders are deleted from a share.

  • if the sharee deletes the file or folder then the deleted file(s) go in the trashbin of the sharee and sharer, but not the trashbin of anyone else who received the share (e.g. when the share was to a group)
  • if the sharer deletes the file or folder then the deleted file(s) go in the trashbin of the sharer only

The "rule" here is that the sharer always has access to the file(s) in their trashbin. The sharee that deletes something also has it in their trashbin (so that they can restore it if/when they realise that they accidentally deleted it)

I thought that we already had scenarios like this, but I couldn't find any - so I added them.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Oct 8, 2021
@phil-davis phil-davis marked this pull request as ready for review October 8, 2021 10:31
@phil-davis phil-davis mentioned this pull request Oct 8, 2021
Closed
@phil-davis phil-davis force-pushed the trashbin-group-tests branch from 97ff6d4 to f788e1b Compare October 8, 2021 12:15
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SwikritiT
SwikritiT reviewed Oct 11, 2021
View reviewed changes
Comment thread tests/acceptance/features/apiTrashbin/trashbinSharingToRoot.feature Outdated
SwikritiT
SwikritiT reviewed Oct 11, 2021
View reviewed changes
Comment thread tests/acceptance/features/apiTrashbin/trashbinSharingToRoot.feature Outdated
SwikritiT
SwikritiT reviewed Oct 11, 2021
View reviewed changes
Comment thread tests/acceptance/features/apiTrashbin/trashbinSharingToRoot.feature Outdated
SwikritiT
SwikritiT reviewed Oct 11, 2021
View reviewed changes
Comment thread tests/acceptance/features/apiTrashbin/trashbinSharingToRoot.feature Outdated
SwikritiT
SwikritiT reviewed Oct 11, 2021
View reviewed changes
Comment thread tests/acceptance/features/apiTrashbin/trashbinSharingToShares.feature Outdated
SwikritiT
SwikritiT reviewed Oct 11, 2021
View reviewed changes
Comment thread tests/acceptance/features/apiTrashbin/trashbinSharingToShares.feature Outdated
SwikritiT
SwikritiT reviewed Oct 11, 2021
View reviewed changes
Comment thread tests/acceptance/features/apiTrashbin/trashbinSharingToShares.feature Outdated
SwikritiT
SwikritiT reviewed Oct 11, 2021
View reviewed changes
Comment thread tests/acceptance/features/apiTrashbin/trashbinSharingToShares.feature Outdated
@phil-davis phil-davis force-pushed the trashbin-group-tests branch from f788e1b to 9bf8eb0 Compare October 11, 2021 16:21
@phil-davis phil-davis requested a review from SwikritiT October 11, 2021 16:21
@kiranparajuli589

kiranparajuli589 commented Oct 19, 2021

Copy link
Copy Markdown
Contributor

https://drone.owncloud.com/owncloud/core/32986/34/10
random failure due to services not ready, ci restarted

@phil-davis

phil-davis commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

I will rebase - this is a lot of commits behind master now.

@phil-davis phil-davis force-pushed the trashbin-group-tests branch from 9bf8eb0 to a7eaaac Compare October 19, 2021 10:26
@phil-davis phil-davis merged commit 7feefc6 into master Oct 19, 2021
@delete-merged-branch delete-merged-branch Bot deleted the trashbin-group-tests branch October 19, 2021 11:28
@phil-davis phil-davis mentioned this pull request Jun 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@individual-it individual-it individual-it approved these changes
@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589
@Talank Talank Awaiting requested review from Talank
@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@phil-davis phil-davis

Labels

QA:team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@phil-davis @kiranparajuli589 @individual-it @SwikritiT @saw-jan