[tests-only] [full-ci] Tests/version metadata continued

[phil-davis]

Description

This is on top of the code in PR #39516 "Version Metadata Continued"

I have adjusted "Scenario: enable file versioning and check the history of changes from multiple users" so that it expects the behavior that I think we want to have.

Related Issue

Part of https://github.com/owncloud/enterprise/issues/4518
and #39504

[phil-davis]

https://drone.owncloud.com/owncloud/core/33854/85/13

  Scenario: enable file versioning and check the history of changes from multiple users                   # /drone/src/tests/acceptance/features/apiVersions/fileVersions.feature:474
    Given the administrator has enabled the file version storage feature                                  # FeatureContext::theAdministratorHasEnabledTheFileVersionStorage()
    And user "Brian" has been created with default attributes and without skeleton files                  # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "Carol" has been created with default attributes and without skeleton files                  # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "David" has been created with default attributes and without skeleton files                  # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "Alice" creates folder "/test" using the WebDAV API                                          # FeatureContext::userCreatesFolder()
    And user "Alice" shares folder "/test" with user "Brian" with permissions "all" using the sharing API # FeatureContext::userSharesFileWithUserUsingTheSharingApi()
    And user "Alice" shares folder "/test" with user "Carol" with permissions "all" using the sharing API # FeatureContext::userSharesFileWithUserUsingTheSharingApi()
    And user "Alice" shares folder "/test" with user "David" with permissions "all" using the sharing API # FeatureContext::userSharesFileWithUserUsingTheSharingApi()
    And user "Alice" has uploaded file with content "uploaded content alice" to "/test/textfile0.txt"     # FeatureContext::userHasUploadedAFileWithContentTo()
    And user "Brian" has uploaded file with content "uploaded content brian" to "/test/textfile0.txt"     # FeatureContext::userHasUploadedAFileWithContentTo()
    And user "Carol" has uploaded file with content "uploaded content carol" to "/test/textfile0.txt"     # FeatureContext::userHasUploadedAFileWithContentTo()
    And user "David" has uploaded file with content "uploaded content david" to "/test/textfile0.txt"     # FeatureContext::userHasUploadedAFileWithContentTo()
    When user "Alice" gets the number of versions of file "/test/textfile0.txt"                           # FilesVersionsContext::userGetsFileVersions()
    Then the number of versions should be "3"                                                             # FeatureContext::theNumberOfVersionsShouldBe()
    When user "Alice" downloads the version of file "/test/textfile0.txt" with the index "1"              # FilesVersionsContext::downloadVersion()
    Then the HTTP status code should be "200"                                                             # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the following headers should be set                                                               # FeatureContext::theFollowingHeadersShouldBeSet()
      | header              | value                                                                |
      | Content-Disposition | attachment; filename*=UTF-8''textfile0.txt; filename="textfile0.txt" |
    And the downloaded content should be "uploaded content carol"                                         # FeatureContext::downloadedContentShouldBe()
    When user "Alice" downloads the version of file "test/textfile0.txt" with the index "2"               # FilesVersionsContext::downloadVersion()
    Then the HTTP status code should be "200"                                                             # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the following headers should be set                                                               # FeatureContext::theFollowingHeadersShouldBeSet()
      | header              | value                                                                |
      | Content-Disposition | attachment; filename*=UTF-8''textfile0.txt; filename="textfile0.txt" |
    And the downloaded content should be "uploaded content brian"                                         # FeatureContext::downloadedContentShouldBe()
    When user "Alice" downloads the version of file "test/textfile0.txt" with the index "3"               # FilesVersionsContext::downloadVersion()
    Then the HTTP status code should be "200"                                                             # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the following headers should be set                                                               # FeatureContext::theFollowingHeadersShouldBeSet()
      | header              | value                                                                |
      | Content-Disposition | attachment; filename*=UTF-8''textfile0.txt; filename="textfile0.txt" |
    And the downloaded content should be "uploaded content alice"                                         # FeatureContext::downloadedContentShouldBe()
    When user "Alice" gets the version metadata of file "/test/textfile0.txt"                             # FilesVersionsContext::userGetsVersionMetadataOfFile()
    Then the author of the created version with index "1" should be "Carol"                               # FeatureContext::theAuthorOfEditedVersionFile()
    And the author of the created version with index "2" should be "Brian"                                # FeatureContext::theAuthorOfEditedVersionFile()
    And the author of the created version with index "3" should be "Alice"                                # FeatureContext::theAuthorOfEditedVersionFile()
      could not find version with index "3"

@IljaN for the usual core oC10 code, this all works expect for the very last test step.
The very first upload of the file by Alice is the oldest version of the file in the version history. That has no "author" associated with it.

"something" needs to happen on the initial file upload to remember who is the file "author".

The other changes to the file (upload-overwrite) do remember correctly who is the "author".

[phil-davis]

https://drone.owncloud.com/owncloud/core/33904/85/13

    Then the author of the created version with index "1" should be "Carol"                               # FeatureContext::theAuthorOfEditedVersionFile()
      could not find version with index "1"

That is strange. It used to happily find the versions with each index. I will have a look at the test code.

Hmmm - the meta-data seems to all come back empty: #39516 (comment)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[phil-davis]

This has been cherry-picked into #39516