Skip to content

Drop PHP 7.3#40005

Closed
phil-davis wants to merge 1 commit into
masterfrom
drop-php-7.3-202204
Closed

Drop PHP 7.3#40005
phil-davis wants to merge 1 commit into
masterfrom
drop-php-7.3-202204

Conversation

@phil-davis

@phil-davis phil-davis commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

Description

This is a PoC demonstrating the changes needed to drop PHP 7.3

composer found the following dependencies that it could update:

$ composer update
Loading composer repositories with package information
Info from https://repo.packagist.org: #StandWithUkraine
Updating dependencies
Lock file operations: 0 installs, 4 updates, 2 removals
  - Removing container-interop/container-interop (1.2.0)
  - Removing laminas/laminas-zendframework-bridge (1.4.1)
  - Upgrading laminas/laminas-filter (2.12.0 => 2.14.0)
  - Upgrading laminas/laminas-inputfilter (2.12.1 => 2.13.0)
  - Upgrading laminas/laminas-servicemanager (3.7.0 => 3.11.2)
  - Upgrading psr/container (1.1.1 => 1.1.2)
Writing lock file
git/owncloud/core/apps/files_external/3rdparty$ composer update
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 1 update, 0 removals
  - Upgrading guzzlehttp/psr7 (1.8.5 => 2.2.1)
  - Locking psr/http-factory (1.0.1)
Writing lock file

Other things that could be done are:

  • bump from phpunit v9 to v10 (if phpunit v10 gets released "soon")
  • bump Symfony v4 to v5
  • check other major versions of dependencies in composer.json and see what could be updated

Related Issue

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Apr 22, 2022
@phil-davis phil-davis force-pushed the drop-php-7.3-202204 branch 2 times, most recently from 7a65868 to d9e113b Compare May 18, 2022 06:05
@phil-davis phil-davis force-pushed the drop-php-7.3-202204 branch 2 times, most recently from fb21c55 to d603f55 Compare May 24, 2022 07:15
@owncloud owncloud deleted a comment from update-docs Bot May 24, 2022
@owncloud owncloud deleted a comment from ownclouders May 24, 2022
@phil-davis phil-davis force-pushed the drop-php-7.3-202204 branch from d603f55 to ca2b0e0 Compare May 25, 2022 14:07
@owncloud owncloud deleted a comment from ownclouders May 25, 2022
@owncloud owncloud deleted a comment from ownclouders May 25, 2022
@owncloud owncloud deleted a comment from ownclouders May 25, 2022
@owncloud owncloud deleted a comment from ownclouders May 25, 2022
@owncloud owncloud deleted a comment from ownclouders May 25, 2022
@phil-davis phil-davis force-pushed the drop-php-7.3-202204 branch from ca2b0e0 to 6b4c199 Compare June 2, 2022 15:34
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis mentioned this pull request Jun 7, 2022
11 tasks
@phil-davis

Copy link
Copy Markdown
Contributor Author

See #40122 for the rebased version of this, with conflicts resolved.

@phil-davis phil-davis closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant