Add a couple of interface definitions#4928
Conversation
There was a problem hiding this comment.
hmmm - if there is a getSystemValue() why not a setSystemValue()?
There was a problem hiding this comment.
Do we want apps to write into config.php? is not really the place to store app values.
There was a problem hiding this comment.
hmm - where did my comments go?
Well accessing config.php has some sec issues as well like getting access to the password salt, database credentials ...
|
Test passed. |
There was a problem hiding this comment.
no return?
no exceptions?
|
Test passed. |
|
Test passed. |
|
Test passed. |
|
Test passed. |
|
@DeepDiver1975 Aren't the issues addressed now? Otherwise I think you should make separate PRs for the different cases @bartv2. We need to get this puppy merged :) |
|
👍 here we go |
Add a couple of interface definitions
see #4863
@DeepDiver1975 @karlitschek @icewind1991 @tanghus @bantu