Fixed FTP and SMB to use rmdir() when deleting folders#6123
Merged
Conversation
Contributor
|
👍 |
Contributor
Author
|
@owncloud-bot please retest this |
Contributor
|
@owncloud-bot retest this please |
|
Test passed. |
Contributor
|
didn't test it but makes sense 👍 |
Contributor
Author
|
@icewind1991 are you ok with this approach ? |
Contributor
|
👍 |
PVince81
pushed a commit
that referenced
this pull request
Nov 29, 2013
Fixed FTP and SMB to use rmdir() when deleting folders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some storages need to use different calls for deleting files or folders,
usually unlink() and rmdir().
Fixes #4532 (SMB dir deletion)
Fixes #5941 (FTP dir deletion)
Note that the extra is_dir() should be fast because it's read from the
stat cache.
Please review @schiesbn @karlitschek @icewind1991 @DeepDiver1975
@icewind1991 the issues you mentioned previously related to making multiple calls to is_dir() won't cause performance issues as they are read from the stat cache (I've checked the smbclient calls)