Publish notification when adding user#28
Conversation
|
|
|
Ready for review @jvillafanez @DeepDiver1975 @IljaN @VicDeo I'll investigate how to kill the notification in case of deletion separately, seems to be tricky. |
There was a problem hiding this comment.
cries for info.xml enhancement ....
There was a problem hiding this comment.
if we had a generic service registration we wouldn't need to enhance core for everything out there
<services><service type="\OC\INotifier">\OCA\CustomGroups\Notifier</service></services>
then core (or any app) could just find all services of a given type/namespace.
That was what I hoped to achieve with https://central.owncloud.org/t/service-based-app-imlpementation-to-solve-inter-app-dependencies/1615
There was a problem hiding this comment.
I could... but I somehow hate having IManager without knowing what a "manager" is.
This should have been called INotificationManager in the first place.
Or I could use use xxx as yyy ?
There was a problem hiding this comment.
I don't want to mock it... too many calls to it and in the end the default one works fine as it will return the same texts untranslated but formatted
|
@DeepDiver1975 fixed the namespace use and added Other pieces aren't blockers from my POV. |
Fixes #4