build(deps-dev): bump sinon from 17.0.2 to 22.0.0#690
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
9f04b49 to
aab3964
Compare
b82e3d0 to
23d95bf
Compare
Bumps [sinon](https://github.com/sinonjs/sinon) from 17.0.2 to 22.0.0. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](sinonjs/sinon@v17.0.2...v22.0.0) --- updated-dependencies: - dependency-name: sinon dependency-version: 22.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
23d95bf to
b4d7c39
Compare
dj4oC
reviewed
Jul 9, 2026
dj4oC
left a comment
Contributor
There was a problem hiding this comment.
- Security: no findings (sinon 17.0.2 → 22.0.0, test devDependency)
- Stability:
JS Unitcheck fails on the head commit; PHP unit/style/lint/semantic-commit all pass. Sinon 17→22 is a large major-version jump likely to change mocking/faketimer APIs, consistent with the JS Unit failure. - Performance: no findings
- Test coverage: n/a
- TODOs found: 0
- Dependency touched: yes — sinon (BSD-3-Clause), major bump
- CI status: failing (JS Unit)
Verdict
Not mergeable as-is — JS Unit is red. Not approving; likely needs test-code updates to match the new Sinon API, not just a version bump.
🤖 Automated review by Claude Code (security · stability · performance · coverage)
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps sinon from 17.0.2 to 22.0.0.
Changelog
Sourced from sinon's changelog.
... (truncated)
Commits
52555af22.0.0ed911dfUpdate Ruby gems75a1e5bUpdate to Node 26197d660Update documentation on faking timers to reflect the current state of fake-ti...c5ddf80Update fake-timers@15.4: includes new Temporal APIf4ab02fUpdate updatable packages0536afcQuality: Global mutable call id can grow unbounded across long-lived processe...f4f7d93Perform additional cleanup when calling callThrough() (#2670)6199e9eimprove GitHubworkflows by introducing zizmor for monitoring (#2686)1519009Merge #2703: isolate walk state from Object prototype