Skip to content

New 2.9 errors#123

Merged
EParzefall merged 2 commits into
masterfrom
faq-errors
Jan 12, 2022
Merged

New 2.9 errors#123
EParzefall merged 2 commits into
masterfrom
faq-errors

Conversation

@michaelstingl

@michaelstingl michaelstingl commented Sep 28, 2021

Copy link
Copy Markdown
Contributor

2.9 came with some new error messages, and they're not easy to resolve. 2.9.1 error messages will link to this page.

Issues:

Testing the PR

git clone git@github.com:owncloud/docs-client-desktop.git
cd docs-client-desktop
git checkout faq-errors
yarn install
yarn antora
yarn serve

Then you can find the changed version here:
http://localhost:8080/desktop/next/faq.html

TODO

  • Add descriptions + solutions/workarounds
  • Add consistent screenshots for each error after @TheOneRing implemented the links

Versions

  • 2.9+

@TheOneRing

This comment has been minimized.

@michaelstingl

This comment has been minimized.

Comment thread modules/ROOT/pages/faq.adoc Outdated
Comment thread modules/ROOT/pages/faq.adoc
Comment thread modules/ROOT/pages/faq.adoc Outdated
@mmattel

mmattel commented Sep 28, 2021

Copy link
Copy Markdown
Contributor

...2.9.1 error messages will link to this page...

  • In case you hardcode links from client to docs, I highly recommend NOT to use anchors to sections but pages only
  • To be future proof, the core team uses a web server sided php script (go.php) like https://doc.owncloud.com/server/10.7/go.php?to=user-sharing-federated
    to access doc resources inside the core code to neutralize access.
    This makes it much easier to adopt targets without changing the source (the desktop client)
    You may create a renamed copy of the php script (like gd.php) at gitea and set the redirects in that script accordingly
  • They core team recently added a check if links are valid, see: Move all doc-links to a collected space, Add command to verify all available doc links core#39026

@EParzefall

Copy link
Copy Markdown
Contributor

I share Martin's concerns with using anchors. The script approach is better in case adjustments are necessary in the future. One place to rule them all.

Comment thread modules/ROOT/pages/faq.adoc
Comment thread modules/ROOT/pages/faq.adoc
@TheOneRing

Copy link
Copy Markdown
Contributor

Typo in file name modules/ROOT/assets/images/faq/older-used-by-different-client.png

Comment thread modules/ROOT/pages/faq.adoc Outdated
Comment thread modules/ROOT/pages/faq.adoc
@michaelstingl

Copy link
Copy Markdown
Contributor Author

@TheOneRing could you review the latest changes?

@TheOneRing

Copy link
Copy Markdown
Contributor

LGTM

@michaelstingl

Copy link
Copy Markdown
Contributor Author

@mmattel @EParzefall could you take over and bring this to life?

@EParzefall EParzefall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some language improvements necessary

Comment thread modules/ROOT/pages/faq.adoc Outdated
Comment thread modules/ROOT/pages/faq.adoc Outdated
Comment thread modules/ROOT/pages/faq.adoc Outdated
Comment thread modules/ROOT/pages/faq.adoc Outdated
Comment thread modules/ROOT/pages/faq.adoc Outdated
Comment thread modules/ROOT/pages/faq.adoc Outdated
Comment thread modules/ROOT/pages/faq.adoc Outdated
Comment thread modules/ROOT/pages/faq.adoc Outdated
Comment thread modules/ROOT/pages/faq.adoc Outdated
Comment thread modules/ROOT/pages/faq.adoc Outdated
@EParzefall EParzefall merged commit cf6e33a into master Jan 12, 2022
@delete-merged-branch delete-merged-branch Bot deleted the faq-errors branch January 12, 2022 13:21
EParzefall added a commit that referenced this pull request Jan 12, 2022
EParzefall added a commit that referenced this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants