New 2.9 errors#123
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
erikjv
reviewed
Sep 28, 2021
mmattel
reviewed
Sep 28, 2021
mmattel
reviewed
Sep 28, 2021
Contributor
|
Contributor
|
I share Martin's concerns with using anchors. The script approach is better in case adjustments are necessary in the future. One place to rule them all. |
TheOneRing
reviewed
Sep 29, 2021
TheOneRing
reviewed
Sep 29, 2021
Contributor
|
Typo in file name modules/ROOT/assets/images/faq/older-used-by-different-client.png |
TheOneRing
reviewed
Sep 29, 2021
TheOneRing
reviewed
Sep 29, 2021
Contributor
Author
|
@TheOneRing could you review the latest changes? |
Contributor
|
LGTM |
Contributor
Author
|
@mmattel @EParzefall could you take over and bring this to life? |
EParzefall
approved these changes
Jan 12, 2022
EParzefall
left a comment
Contributor
There was a problem hiding this comment.
Some language improvements necessary
language review
This was referenced Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.9 came with some new error messages, and they're not easy to resolve.
2.9.1 error messages will link to this page.Issues:
Testing the PR
Then you can find the changed version here:
http://localhost:8080/desktop/next/faq.html
TODO
Versions