Skip to content

Document ability to open the file sidebar from a permalink#1228

Merged
settermjd merged 9 commits into
masterfrom
document-link-to-open-file-sidebar-from-permalink
May 28, 2019
Merged

Document ability to open the file sidebar from a permalink#1228
settermjd merged 9 commits into
masterfrom
document-link-to-open-file-sidebar-from-permalink

Conversation

@settermjd

@settermjd settermjd commented May 20, 2019

Copy link
Copy Markdown
Contributor

This fixes #265 and relates to owncloud/core#32152. It details the ability to open one of three file sidebars (versions, comments, and shares) by using a permalink. I wasn't quite sure where to document this feature. The three locations that it has been documented in this PR seemed the best places (at least so far).

💁‍♂ Only backport to 10.2.

This fixes #265 and relates to
owncloud/core#32152. It details the ability to
open one of three file sidebars (versions, comments, and shares) by
using a permalink.

@michaelstingl michaelstingl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a new capability for it. Otherwise it doesn't make sense for the clients. Capability docs are super outdated, but we could add at least the new ones…

@settermjd

Copy link
Copy Markdown
Contributor Author

@michaelstingl, can you provide a description of the new capability pls?

@michaelstingl

Copy link
Copy Markdown
Contributor

@michaelstingl, can you provide a description of the new capability pls?

sure: owncloud/core#35104

@settermjd settermjd added the p3-medium Normal priority label May 27, 2019
@settermjd

Copy link
Copy Markdown
Contributor Author

@michaelstingl

Copy link
Copy Markdown
Contributor

@michaelstingl, do you just need the new capability added to https://doc.owncloud.com/server/developer_manual/core/ocs-capabilities.html#available-capabilities?

yes 👍

@settermjd

Copy link
Copy Markdown
Contributor Author

@michaelstingl, the capability has been documented. Is this PR ready for merge?

@michaelstingl

Copy link
Copy Markdown
Contributor

@michaelstingl, the capability has been documented. Is this PR ready for merge?

Add a new section below with the explanation?

@settermjd

Copy link
Copy Markdown
Contributor Author

@michaelstingl, the capability has been documented. Is this PR ready for merge?

Add a new section below with the explanation?

Does a9a3833 do what you're after?

@michaelstingl michaelstingl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, should work now

My local build:
OCS_Rest_API____ownCloud_Documentation

@settermjd settermjd merged commit 397c02c into master May 28, 2019
@delete-merged-branch delete-merged-branch Bot deleted the document-link-to-open-file-sidebar-from-permalink branch May 28, 2019 12:59
settermjd added a commit that referenced this pull request May 28, 2019
settermjd added a commit that referenced this pull request May 28, 2019
settermjd added a commit that referenced this pull request May 28, 2019
phil-davis pushed a commit that referenced this pull request May 28, 2019
phil-davis pushed a commit that referenced this pull request May 28, 2019
phil-davis pushed a commit that referenced this pull request May 28, 2019
settermjd added a commit that referenced this pull request Jul 22, 2019
* Document ability to open the file sidebar from a permalink
* Document the new privateLinksDetailsParam capability
* Add privateLinksDetailsParam to Files capabilities element description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link to open file sidebar from permalink

2 participants