Revert private links details param 10.0#1285
Merged
Merged
Conversation
phil-davis
commented
May 29, 2019
| |`versioning` | ||
|
|
||
| |Navigating directly to a file's version, comments, and sharing pane | ||
| |`privatelLinks` and `privateLinksDetailsParam` |
Contributor
Author
There was a problem hiding this comment.
I took these lines out completely, because I am not sure anyway what "Navigating directly" has to do with privateLinks - I will look into it...
Contributor
Author
There was a problem hiding this comment.
privateLinks capability was added in core PR owncloud/core#29021
It refers to the capability that core DAV can return a private link to a file.
So I do not see what this has to do with "Navigating directly"
settermjd
approved these changes
May 29, 2019
Contributor
|
Thanks for creating the PR, @phil-davis. |
Contributor
Author
|
See PR #1286 for this revert in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
privateLinksDetailsParamwas only added in 10.2Revert parts of the changes that were backported to
10.0in PR #1280