Fix build errors (#1754)#1925
Merged
Merged
Conversation
* Fix up incorrect header levels Some of the headers were at inconsistent nesting levels within the structure of the page that they were one, others were not included with the correct level offset. Both of these situations are corrected in this change. * Update references to totp user is not found response examples The include link to the JSON example was corrected and the XML example file was updated to keep consistency with the JSON example as well as the section. The last thing that I want to have happen is to have confusion at some future point as to whether the XML file should be there, is incorrectly linked, etc, all because of a minor name difference. * Fix missing attribute reference warnings There were a number of places where either the attribute wasn't defined, wasn't being passed on to an included file, or was being incorrectly interpreted as an attribute. This change corrects all of these problems. * Remove unnecessary custom ids These aren't necessary, as ones exactly the same will be generated by Antora.
settermjd
force-pushed
the
10.0-06b7fbe-1754
branch
from
October 11, 2019 07:24
ad8383c to
1347bbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the headers were at inconsistent nesting levels within the
structure of the page that they were one, others were not included with
the correct level offset. Both of these situations are corrected in this
change.
The include link to the JSON example was corrected and the XML example
file was updated to keep consistency with the JSON example as well as
the section. The last thing that I want to have happen is to have
confusion at some future point as to whether the XML file should be
there, is incorrectly linked, etc, all because of a minor name
difference.
There were a number of places where either the attribute wasn't defined,
wasn't being passed on to an included file, or was being incorrectly
interpreted as an attribute. This change corrects all of these problems.
These aren't necessary, as ones exactly the same will be generated by
Antora.