Skip to content

Document WebDAV Search API#224

Merged
settermjd merged 5 commits into
masterfrom
document-webdav-search-api
Nov 19, 2018
Merged

Document WebDAV Search API#224
settermjd merged 5 commits into
masterfrom
document-webdav-search-api

Conversation

@settermjd

@settermjd settermjd commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

This PR documents two reports in the WebDAV Search API, file-filter and search-files. It fixes owncloud/core#31873.

This PR makes extensive use of Antora's include directive, including both examples and partials. As a result, it may make the content a bit hard to review directly in GitHub. If you build the documentation locally, it will be much easier to review.

@settermjd settermjd added enhancement New feature or request work in progress Still in development. Not to be merged. command-line labels Nov 13, 2018
@settermjd settermjd self-assigned this Nov 13, 2018
@settermjd
settermjd force-pushed the document-webdav-search-api branch from 84215b1 to fc5f275 Compare November 13, 2018 13:27
mmattel
mmattel previously approved these changes Nov 13, 2018

@mmattel mmattel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@settermjd
settermjd force-pushed the document-webdav-search-api branch 2 times, most recently from 730437c to 0fad8b3 Compare November 14, 2018 12:21
@jvillafanez

Copy link
Copy Markdown
Member

The search-files report will use the ownCloud's search API, with whatever search implementation is available. In particular, if search_elastic or search_lucene apps are installed, they'll be used. The report will remain the same, but the returned files might be different according to however those apps are configured. Not sure if it's worthy to comment it here.

For the rest, it looks good to me.

@settermjd

Copy link
Copy Markdown
Contributor Author

@jvillafanez, can you provide more context to your comment? I don't quite get where it fits in or what needs to be changed to accommodate it.

@settermjd
settermjd force-pushed the document-webdav-search-api branch from 5f88263 to 6b11d03 Compare November 15, 2018 08:19
@jvillafanez

Copy link
Copy Markdown
Member

Normally, the search will be done by the default search provider. This implies that the search pattern will only match the filenames.
There are other search providers such as search_elastic and search_lucene which can enrich the search to search by file content, for example. If those apps (or any other related to searching) are installed, the search API will use them.

For example, if you search "ownCloud" you'll get files whose filename has "ownCloud" in it. In case you have search_elastic, by doing the exact same search you'll also get files having "ownCloud" in the contents.

@settermjd

Copy link
Copy Markdown
Contributor Author

Ah, I understand now. Thanks for the clarification @jvillafanez. How is the search provider specified?

@jvillafanez

Copy link
Copy Markdown
Member

I guess the app itself takes care of the registration, so it's a matter of install the app the configure it properly. I don't think there is any additional thing to do.
So there is no need to specify the search provider.

@settermjd

Copy link
Copy Markdown
Contributor Author

Just specify the note about search options, based on the different search providers?

@settermjd
settermjd force-pushed the document-webdav-search-api branch from 6b11d03 to c0cafa6 Compare November 15, 2018 14:04
@jvillafanez

Copy link
Copy Markdown
Member

Yes, it should be fine.

@settermjd
settermjd force-pushed the document-webdav-search-api branch from c0cafa6 to cb0c0c3 Compare November 16, 2018 08:07
@settermjd

Copy link
Copy Markdown
Contributor Author

@jvillafanez, note added. Please let me know if you're okay with it.

Comment thread modules/developer_manual/pages/webdav_api/search/search_files.adoc Outdated
This relates to owncloud/core#31873 and
documents the search-files report of ownCloud's Search API.
Before, the file organisation was descending into a mess, so it needed
to be stopped and fixed before it became complete chaos. This commit
does that.
@settermjd
settermjd force-pushed the document-webdav-search-api branch from 2364927 to 15764e0 Compare November 19, 2018 10:00
This commit adds a note about the functionality that search apps provide
over the default search provider.
@settermjd
settermjd force-pushed the document-webdav-search-api branch from 15764e0 to ff3e1ed Compare November 19, 2018 10:02
@settermjd
settermjd merged commit 92246cc into master Nov 19, 2018
@settermjd
settermjd deleted the document-webdav-search-api branch November 19, 2018 10:02
@settermjd settermjd mentioned this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request work in progress Still in development. Not to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants