Skip to content

Document how we write acceptance tests#398

Merged
settermjd merged 2 commits into
masterfrom
acceptance-test-behat-gherkin-issue-156
Nov 21, 2018
Merged

Document how we write acceptance tests#398
settermjd merged 2 commits into
masterfrom
acceptance-test-behat-gherkin-issue-156

Conversation

@phil-davis

@phil-davis phil-davis commented Nov 20, 2018

Copy link
Copy Markdown
Contributor

Update and add to the acceptance test documentation.

This PR is aimed at:

  • document the standard grammar forms that we are using to write Given When and Then step text
  • give guidelines for how to write the code for new API acceptance test steps
  • give guidelines for how to write the code for new CLI acceptance test steps
  • give guidelines on what makes a "good" test scenario
  • how to write scenarios for bugs Documenting existing behavior when bugs are found QA#601

from issue #156

@phil-davis phil-davis added the work in progress Still in development. Not to be merged. label Nov 20, 2018
@phil-davis phil-davis self-assigned this Nov 20, 2018
@phil-davis phil-davis mentioned this pull request Nov 20, 2018
17 tasks
Comment thread modules/developer_manual/pages/core/acceptance-tests.adoc Outdated

@settermjd settermjd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the whole it looks great, just a few points that need addressing.

@phil-davis phil-davis force-pushed the acceptance-test-behat-gherkin-issue-156 branch from b3fc042 to 03b604e Compare November 21, 2018 03:48
Comment thread modules/developer_manual/pages/core/acceptance-tests.adoc Outdated
Comment thread modules/developer_manual/pages/core/acceptance-tests.adoc Outdated
mmattel
mmattel previously approved these changes Nov 21, 2018

@mmattel mmattel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant comment on the acceptance test content, but the text looks good

@settermjd settermjd force-pushed the acceptance-test-behat-gherkin-issue-156 branch from e89c48e to 324d7c1 Compare November 21, 2018 10:35
@settermjd settermjd merged commit 39427fa into master Nov 21, 2018
@settermjd settermjd deleted the acceptance-test-behat-gherkin-issue-156 branch November 21, 2018 11:31
@phil-davis

Copy link
Copy Markdown
Contributor Author

This was work-in-progress. Anyway, what I had so far was a good start! I will pull master and start a new branch and PR for the next parts.

@mmattel

mmattel commented Nov 21, 2018

Copy link
Copy Markdown
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work in progress Still in development. Not to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants