Document how we write acceptance tests#398
Merged
Merged
Conversation
17 tasks
settermjd
reviewed
Nov 20, 2018
settermjd
suggested changes
Nov 20, 2018
settermjd
left a comment
Contributor
There was a problem hiding this comment.
On the whole it looks great, just a few points that need addressing.
b3fc042 to
03b604e
Compare
mmattel
reviewed
Nov 21, 2018
mmattel
reviewed
Nov 21, 2018
mmattel
previously approved these changes
Nov 21, 2018
mmattel
left a comment
Contributor
There was a problem hiding this comment.
I cant comment on the acceptance test content, but the text looks good
e89c48e to
324d7c1
Compare
settermjd
approved these changes
Nov 21, 2018
Contributor
Author
|
This was work-in-progress. Anyway, what I had so far was a good start! I will pull master and start a new branch and PR for the next parts. |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update and add to the acceptance test documentation.
This PR is aimed at:
from issue #156