Nightly failed on apiMain/quotaOc10Issue40140 feature

[grgprarup]

Drone builds: https://drone.owncloud.com/owncloud/encryption/2515/31/19
https://drone.owncloud.com/owncloud/encryption/2515/71/19

Scenario: apiMain/quotaOc10Issue40140.feature:9

Scenario: share receiver with insufficient quota should not be able to copy received shared file to home folder # /var/www/owncloud/testrunner/tests/acceptance/features/apiMain/quotaOc10Issue40140.feature:9
    Given the administrator has set the default folder for received shares to "Shares"                            # OccContext::theAdministratorHasSetTheDefaultFolderForReceivedSharesTo()
    And auto-accept shares has been disabled                                                                      # FeatureContext::autoAcceptSharesHasBeenDisabled()
    And user "Brian" has been created with default attributes and without skeleton files                          # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And the quota of user "Brian" has been set to "10 B"                                                          # FeatureContext::theQuotaOfUserHasBeenSetTo()
    And the quota of user "Alice" has been set to "10 MB"                                                         # FeatureContext::theQuotaOfUserHasBeenSetTo()
    And user "Alice" has uploaded file with content "test-content-15" to "/testquota.txt"                         # FeatureContext::userHasUploadedAFileWithContentTo()
    And user "Alice" has shared file "/testquota.txt" with user "Brian"                                           # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Brian" has accepted share "/testquota.txt" offered by user "Alice"                                  # FeatureContext::userHasReactedToShareOfferedBy()
    When user "Brian" copies file "/Shares/testquota.txt" to "/testquota.txt" using the WebDAV API                # FeatureContext::userCopiesFileUsingTheAPI()
    Then the HTTP status code should be "201"                                                                     # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And as "Brian" file "/testquota.txt" should not exist                                                         # FeatureContext::asFileOrFolderShouldNotExist()
      file '/testquota.txt' should not exist. But it does exist and is a file

Scenario: apiMain/quotaOc10Issue40140.feature:27

Scenario: share receiver with insufficient quota should not be able to copy file from shared folder to home folder # /var/www/owncloud/testrunner/tests/acceptance/features/apiMain/quotaOc10Issue40140.feature:27
    Given the administrator has set the default folder for received shares to "Shares"                               # OccContext::theAdministratorHasSetTheDefaultFolderForReceivedSharesTo()
    And auto-accept shares has been disabled                                                                         # FeatureContext::autoAcceptSharesHasBeenDisabled()
    And user "Brian" has been created with default attributes and without skeleton files                             # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And the quota of user "Brian" has been set to "10 B"                                                             # FeatureContext::theQuotaOfUserHasBeenSetTo()
    And the quota of user "Alice" has been set to "10 MB"                                                            # FeatureContext::theQuotaOfUserHasBeenSetTo()
    And user "Alice" has created folder "shareFolder"                                                                # FeatureContext::userHasCreatedFolder()
    And user "Alice" has uploaded file with content "test-content-15" to "/shareFolder/testquota.txt"                # FeatureContext::userHasUploadedAFileWithContentTo()
    And user "Alice" has shared folder "/shareFolder" with user "Brian"                                              # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Brian" has accepted share "/shareFolder" offered by user "Alice"                                       # FeatureContext::userHasReactedToShareOfferedBy()
    When user "Brian" copies file "/Shares/shareFolder/testquota.txt" to "/testquota.txt" using the WebDAV API       # FeatureContext::userCopiesFileUsingTheAPI()
    Then the HTTP status code should be "201"                                                                        # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And as "Brian" file "/testquota.txt" should not exist                                                            # FeatureContext::asFileOrFolderShouldNotExist()
      file '/testquota.txt' should not exist. But it does exist and is a file

Scenario: apiMain/quotaOc10Issue40140.feature:68

Scenario: share receiver of a share with insufficient quota should not be able to copy file from home folder to the received shared folder # /var/www/owncloud/testrunner/tests/acceptance/features/apiMain/quotaOc10Issue40140.feature:68
    Given the administrator has set the default folder for received shares to "Shares"                                                       # OccContext::theAdministratorHasSetTheDefaultFolderForReceivedSharesTo()
    And auto-accept shares has been disabled                                                                                                 # FeatureContext::autoAcceptSharesHasBeenDisabled()
    And user "Brian" has been created with default attributes and without skeleton files                                                     # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And the quota of user "Brian" has been set to "10 MB"                                                                                    # FeatureContext::theQuotaOfUserHasBeenSetTo()
    And the quota of user "Alice" has been set to "10 B"                                                                                     # FeatureContext::theQuotaOfUserHasBeenSetTo()
    And user "Alice" has created folder "shareFolder"                                                                                        # FeatureContext::userHasCreatedFolder()
    And user "Alice" has shared folder "/shareFolder" with user "Brian"                                                                      # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Brian" has accepted share "/shareFolder" offered by user "Alice"                                                               # FeatureContext::userHasReactedToShareOfferedBy()
    And user "Brian" has uploaded file with content "test-content-15" to "/testquota.txt"                                                    # FeatureContext::userHasUploadedAFileWithContentTo()
    When user "Brian" copies file "/testquota.txt" to "/Shares/shareFolder/testquota.txt" using the WebDAV API                               # FeatureContext::userCopiesFileUsingTheAPI()
    Then the HTTP status code should be "201"                                                                                                # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And as "Brian" file "/testquota.txt" should exist                                                                                        # FeatureContext::asFileOrFolderShouldExist()
    And as "Alice" file "/shareFolder/testquota.txt" should not exist                                                                        # FeatureContext::asFileOrFolderShouldNotExist()
      file '/shareFolder/testquota.txt' should not exist. But it does exist and is a file

Tests are failing and might be relevant to the PR in core owncloud/core#40141.

[phil-davis]

It is interesting that the scenarios at line 46 passes:

  Scenario: share receiver of a share with insufficient quota should not be able to copy from home folder to the received shared file # /var/www/owncloud/testrunner/tests/acceptance/features/apiMain/quotaOc10Issue40140.feature:46
    Given the administrator has set the default folder for received shares to "Shares"                                                # OccContext::theAdministratorHasSetTheDefaultFolderForReceivedSharesTo()
    And auto-accept shares has been disabled                                                                                          # FeatureContext::autoAcceptSharesHasBeenDisabled()
    And user "Brian" has been created with default attributes and without skeleton files                                              # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And the quota of user "Brian" has been set to "10 MB"                                                                             # FeatureContext::theQuotaOfUserHasBeenSetTo()
    And the quota of user "Alice" has been set to "10 B"                                                                              # FeatureContext::theQuotaOfUserHasBeenSetTo()
    And user "Alice" has uploaded file with content "short" to "/testquota.txt"                                                       # FeatureContext::userHasUploadedAFileWithContentTo()
    And user "Brian" has uploaded file with content "longer line of text" to "/testquota.txt"                                         # FeatureContext::userHasUploadedAFileWithContentTo()
    And user "Alice" has shared file "/testquota.txt" with user "Brian"                                                               # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Brian" has accepted share "/testquota.txt" offered by user "Alice"                                                      # FeatureContext::userHasReactedToShareOfferedBy()
    When user "Brian" copies file "/testquota.txt" to "/Shares/testquota.txt" using the WebDAV API                                    # FeatureContext::userCopiesFileUsingTheAPI()
    Then the HTTP status code should be "204"                                                                                         # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And as "Brian" file "/Shares/testquota.txt" should exist                                                                          # FeatureContext::asFileOrFolderShouldExist()
    And as "Alice" file "/testquota.txt" should exist                                                                                 # FeatureContext::asFileOrFolderShouldExist()
    And the content of file "/testquota.txt" for user "Alice" should be "short"                                                       # FeatureContext::contentOfFileForUserShouldBe()

That is a slightly different situation where the COPY is overwriting an existing small file with a bigger file that exceeds the quota.

[phil-davis]

The fails are the same against core master and latest (10.10.0) so it looks like there is a difference in behavior with encryption. As well as returning unexpected "success" codes like 201 for the COPY, the copy of the file does actually exist. But in core, without encryption, something in the server does not actually create the file (the "success" status is fake - the copy does actually fail, as it should)

[phil-davis]

@grgprarup please assign someone to:

• skip the 3 core scenarios on encryption
• create a quotaOc10Issue40140.feature in the encryption app apiEncryption suite
• add 3 similar bug-demo scenarios to that feature, with a Then step at the end that passes, and demonstrates the way the bug behaves with encryption