The signature check done during decryption is bypassed#105
Closed
sharidas wants to merge 1 commit into
Closed
Conversation
The signature check done during decryption is bypassed. This would help to not block files transferred from one user to another. Signed-off-by: Sujith H <sharidasan@owncloud.com>
12 tasks
Contributor
Author
|
Requires PR - owncloud/core#34710 |
PVince81
suggested changes
Mar 7, 2019
PVince81
left a comment
PVince81
left a comment
Contributor
There was a problem hiding this comment.
as discussed, this is a bit too convoluted and there are concerns:
- this would always bypass signature check even outside of transfer ownership
- gather file list in an array has a risk of memory overflow with lots of files
Let's try with a simpler solution instead in a separate PR: throw the exception out and let the transfer command log the file name. Then have a flag to disable signature check for the transfer command to retry with it disabled after a failure. Then reenable after each file.
Contributor
Author
|
Closing this PR on behalf of #115 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The signature check done during decryption is
bypassed. This would help to not block files
transferred from one user to another.
Signed-off-by: Sujith H sharidasan@owncloud.com