[Plugin] do not convert mtime to int #172
Closed
moscicki wants to merge 3 commits into
Closed
Conversation
- Fix mtime type missmatch when saving file
|
By analyzing the blame information on this pull request, we identified @schiesbn, @DeepDiver1975 and @nickvergessen to be potential reviewers |
Contributor
|
looks good, only affects 8.2? Or should this also be done on master and 9.0? |
|
It should be done in all of them, since our storage backend will always provide the mtime as a float. Another option is to send the mtime from the client to the server as a float. |
PUT is intended to create objects (usually, using directly the url object). In our case, our webserver warp the file access (moreover, we do are not creating the file, we are updating it, which makes POST more suitable than PUT)
Adding missing file in the previous commit
This was referenced Jul 4, 2017
Contributor
|
@DeepDiver1975 @PVince81 |
Contributor
|
why change from PUT to POST ? |
Contributor
|
This can be closed because of owncloud/core#28066 (make sure mtime is always an int) (merged) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our storage reports mtime with mililseconds (float). Comnverting to int means that the mtimes always mismatch and file cannot be saved.