Acceptance tests by bhawanaprasain · Pull Request #104 · owncloud/firstrunwizard

bhawanaprasain · 2019-04-25T09:52:28Z

When users are created in ownCloud for the first time or when previously created users log into ownCloud this code does automated testing on activities of Firstrunwizard .

codecov · 2019-04-25T10:07:50Z

Codecov Report

Merging #104 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage     28.07%   28.07%           
  Complexity       16       16           
=========================================
  Files             9        9           
  Lines           114      114           
=========================================
  Hits             32       32           
  Misses           82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629c8b9...930a234. Read the comment docs.

codecov · 2019-04-25T10:07:51Z

Codecov Report

Merging #104 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage     28.07%   28.07%           
  Complexity       16       16           
=========================================
  Files             9        9           
  Lines           114      114           
=========================================
  Hits             32       32           
  Misses           82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629c8b9...f4e3570. Read the comment docs.

skshetry · 2019-04-29T04:04:48Z

Tests are failing as composer.json is missing.

+ make test-acceptance-webui
composer install
Do not run Composer as root/super user! See https://getcomposer.org/root for details
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Package operations: 1 install, 0 updates, 0 removals
  - Installing bamarni/composer-bin-plugin (v1.3.0): Downloading (connecting...)���������������������������Downloading (0%)           ���������������������������Downloading (55%)�����������������Downloading (100%)
Generating autoload files
make: *** No rule to make target 'vendor-bin/behat/composer.json', needed by 'vendor-bin/behat/composer.lock'. Stop.

bhawanaprasain · 2019-04-30T09:20:34Z

@phil-davis please review again

phil-davis

I don't see changes yet. Did you forget to push to GitHub?

bhawanaprasain · 2019-05-02T03:45:50Z

@phil-davis please review again

Needs further review

individual-it · 2019-05-02T08:39:12Z

@phil-davis @skshetry @dpakach please review again

skshetry · 2019-05-02T08:45:08Z

Looks good to me. Just a minor suggestion from me.

Next PRs could have more scenarios and share steps between each scenarios. 👍

bhawanaprasain · 2019-05-03T03:40:32Z

@dpakach @skshetry please review again.

individual-it requested review from dpakach, paurakhsharma, phil-davis and skshetry April 25, 2019 09:53

individual-it assigned bhawanaprasain Apr 25, 2019

individual-it added the 3 - To Review label Apr 25, 2019

skshetry reviewed Apr 25, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php Outdated

skshetry reviewed Apr 25, 2019

View reviewed changes

Comment thread tests/acceptance/features/webUIFirstrunwizard/firstrunwizard.feature Outdated

skshetry reviewed Apr 25, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php Outdated

individual-it force-pushed the acceptanceTests branch from 184eb70 to 930a234 Compare April 25, 2019 10:03

dpakach previously requested changes Apr 25, 2019

View reviewed changes

skshetry reviewed Apr 25, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php Outdated

skshetry reviewed Apr 25, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php Outdated

skshetry reviewed Apr 25, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php Outdated

skshetry reviewed Apr 25, 2019

View reviewed changes

Comment thread tests/acceptance/features/lib/FirstrunwizardPage.php Outdated

skshetry reviewed Apr 25, 2019

View reviewed changes

Comment thread tests/acceptance/features/lib/FirstrunwizardPage.php

skshetry reviewed Apr 25, 2019

View reviewed changes

Comment thread tests/acceptance/features/lib/FirstrunwizardPage.php Outdated

bhawanaprasain force-pushed the acceptanceTests branch from 930a234 to f813317 Compare April 25, 2019 10:59

skshetry reviewed Apr 29, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php Outdated

bhawanaprasain force-pushed the acceptanceTests branch 4 times, most recently from 36bf07f to 1a4dbd8 Compare April 29, 2019 07:42

dpakach reviewed Apr 29, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php Outdated

bhawanaprasain force-pushed the acceptanceTests branch from 1a4dbd8 to 34a2051 Compare April 29, 2019 11:11

skshetry reviewed Apr 29, 2019

View reviewed changes

Comment thread tests/acceptance/features/webUIFirstrunwizard/reset_all.feature Outdated

phil-davis reviewed Apr 29, 2019

View reviewed changes

bhawanaprasain force-pushed the acceptanceTests branch 2 times, most recently from aac5022 to 19c42e1 Compare April 30, 2019 07:13

phil-davis reviewed May 2, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php Outdated

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php Outdated

bhawanaprasain force-pushed the acceptanceTests branch from 19c42e1 to 751fb6c Compare May 2, 2019 03:38

bhawanaprasain force-pushed the acceptanceTests branch from 751fb6c to 0b6a2df Compare May 2, 2019 05:46

dpakach self-requested a review May 2, 2019 06:08

dpakach reviewed May 2, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php

dpakach reviewed May 2, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php Outdated

dpakach reviewed May 2, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php

bhawanaprasain force-pushed the acceptanceTests branch 2 times, most recently from e5d0522 to 237587a Compare May 2, 2019 08:09

skshetry reviewed May 2, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php Outdated

dpakach reviewed May 2, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/WebUIFirstrunwizardContext.php Outdated

UI tests for FirstRunWizard

f4e3570

bhawanaprasain force-pushed the acceptanceTests branch from 237587a to f4e3570 Compare May 3, 2019 03:31

dpakach reviewed May 3, 2019

View reviewed changes

Comment thread tests/acceptance/features/bootstrap/bootstrap.php

individual-it approved these changes May 3, 2019

View reviewed changes

individual-it merged commit 3c30ccc into owncloud:master May 3, 2019

individual-it mentioned this pull request May 6, 2019

10.2 - Changelog Test Results owncloud/core#35020

Closed

skshetry mentioned this pull request May 13, 2019

Add acceptance tests for new changes/fixes in v10.2.0 owncloud/core#35207

Closed

Uh oh!

Conversation

bhawanaprasain commented Apr 25, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Apr 25, 2019

Codecov Report

Uh oh!

codecov Bot commented Apr 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skshetry commented Apr 29, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bhawanaprasain commented Apr 30, 2019

Uh oh!

phil-davis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bhawanaprasain commented May 2, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

individual-it commented May 2, 2019

Uh oh!

Uh oh!

skshetry commented May 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bhawanaprasain commented May 3, 2019

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Apr 25, 2019 •

edited

Loading

skshetry commented May 2, 2019 •

edited

Loading