Skip to content

Add occ command to reset for all users#83

Merged
PVince81 merged 1 commit into
masterfrom
feature/reset-all
Feb 13, 2019
Merged

Add occ command to reset for all users#83
PVince81 merged 1 commit into
masterfrom
feature/reset-all

Conversation

@tomneedham

@tomneedham tomneedham commented Nov 9, 2018

Copy link
Copy Markdown

For admins to show new features / clients / manuals to their users, then can theme the firstrunwizard again and trigger it nicely

  • Test on Config class method

@DeepDiver1975

Copy link
Copy Markdown
Member

occ already has a command to set user preferences .... maybe we add an option --all-users over there?

@tomneedham

Copy link
Copy Markdown
Author

Possibly - but that feels like handing a loaded gun to admins - at least this is contained to a flag that is expected to be on all users, and has limited impact.

@PVince81

PVince81 commented Nov 9, 2018

Copy link
Copy Markdown
Contributor

I wonder if we need a base class in core for all commands that apply to all users... The number of commands with "one user", "multiple users" or "multiple group" or "all" as arguments is increasing and we keep on reimplementing.

@tomneedham

Copy link
Copy Markdown
Author

Rebased

@PVince81

Copy link
Copy Markdown
Contributor

please take over. goal is just to finish, no need to add further options for now

@PVince81

Copy link
Copy Markdown
Contributor

@sharidas ^

@PVince81 PVince81 added this to the development milestone Feb 12, 2019
@codecov

codecov Bot commented Feb 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #83 into master will increase coverage by 0.59%.
The diff coverage is 30.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
+ Coverage     27.47%   28.07%   +0.59%     
- Complexity       10       16       +6     
============================================
  Files             8        9       +1     
  Lines            91      114      +23     
============================================
+ Hits             25       32       +7     
- Misses           66       82      +16
Impacted Files Coverage Δ Complexity Δ
lib/Command/ResetAll.php 0% <0%> (ø) 4 <4> (?)
lib/config.php 100% <100%> (ø) 9 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17a10f...e4e4527. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Feb 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #83 into master will increase coverage by 0.59%.
The diff coverage is 30.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #83      +/-   ##
============================================
+ Coverage     27.47%   28.07%   +0.59%     
- Complexity       10       16       +6     
============================================
  Files             8        9       +1     
  Lines            91      114      +23     
============================================
+ Hits             25       32       +7     
- Misses           66       82      +16
Impacted Files Coverage Δ Complexity Δ
lib/Command/ResetAll.php 0% <0%> (ø) 4 <4> (?)
lib/config.php 100% <100%> (ø) 9 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17a10f...e4e4527. Read the comment docs.

@sharidas

sharidas commented Feb 13, 2019

Copy link
Copy Markdown

Ouch. I wonder if this is tested. Sorry no offense here. Or may be its missed to commit :). But this app has missing namespace in the info.xml. And as a result the command occ fails. I have updated the PR with the same. Below is the result I have verified in the console:

 sujith@sujith-ownCloud  ~/test/owncloud3   master ●  ./occ firstrunwizard:reset-all
Cannot load Xdebug - it was already loaded
Resetting firstrunwizard for all users
    1 [============================]
Done
 sujith@sujith-ownCloud  ~/test/owncloud3   master ● 

@sharidas

Copy link
Copy Markdown

@PVince81 The pull request is ready for review. The CI is cleared.

@tomneedham

Copy link
Copy Markdown
Author

But this app has missing namespace in the info.xml. And as a result the command occ fails.

Nice spot. My guess is a osx vs linux filesystem casing issue I've seen before with the autoloader. So probably worked for me locally but on a linux box it dies. Good catch!

@PVince81 PVince81 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
PVince81 merged commit 3c2656f into master Feb 13, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the feature/reset-all branch February 13, 2019 13:31
@PVince81

Copy link
Copy Markdown
Contributor

as firstrunwizard is bundled, we might want to add this addition in the core changelog or release notes only ? @pmaier1

@pmaier1

pmaier1 commented Feb 14, 2019

Copy link
Copy Markdown

core changelog or release notes

both, plx

@phil-davis

Copy link
Copy Markdown
Contributor

Backport stable10 #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants