Skip to content

Adjust expected sharing dialog box text#336

Merged
phil-davis merged 2 commits into
masterfrom
fix-acceptance-tests-20190617
Jun 17, 2019
Merged

Adjust expected sharing dialog box text#336
phil-davis merged 2 commits into
masterfrom
fix-acceptance-tests-20190617

Conversation

@phil-davis

@phil-davis phil-davis commented Jun 17, 2019

Copy link
Copy Markdown
Contributor

Description

core PR owncloud/core#35397 changed the display of the various types of users in the webUI sharing dropdown list.

Adjust the test expectation here in the guests app.

Related Issue

owncloud/core#35098

Motivation and Context

guests app acceptance tests started failing.
Make them great again.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov

codecov Bot commented Jun 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #336 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #336   +/-   ##
=========================================
  Coverage     17.87%   17.87%           
  Complexity      101      101           
=========================================
  Files            11       11           
  Lines           537      537           
=========================================
  Hits             96       96           
  Misses          441      441

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f325dc...50e7a7f. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Jun 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #336 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #336   +/-   ##
=========================================
  Coverage     17.87%   17.87%           
  Complexity      101      101           
=========================================
  Files            11       11           
  Lines           537      537           
=========================================
  Hits             96       96           
  Misses          441      441

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f325dc...50e7a7f. Read the comment docs.

@phil-davis phil-davis merged commit b1684c6 into master Jun 17, 2019
@delete-merged-branch delete-merged-branch Bot deleted the fix-acceptance-tests-20190617 branch June 17, 2019 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants