Adjust guest sharing dropdown text

[phil-davis]

Description

The recent enhancement of the webUI sharing dropdown list in core PR owncloud/core#35397 now puts the user type (local, federated, guest etc) on a second line. The extra (guest) in brackets that the guest app is putting is no longer needed and just adds redundant data to the user experience.

Remove the (guest) in brackets from the sharing dropdown list.

Related Issue

owncloud/core#35098

Motivation and Context

Make the guests sharing webUI behavior match the recent changes in the core PR owncloud/core#35397

How Has This Been Tested?

Observing local webUI test runs to see that the share dropdown no longer has the extra (guest) text.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[phil-davis]

Note: this change to the guests app will need to be released in sync with the release of the corresponding change in core.

Probably that will be core 10.3 - when that is known definitely then a guests app release with this PR would need to have min-version set to 10.3

[pmaier1]

Nice! Thanks a lot for taking care 👍
@patrickjahns we need to schedule a guests app release as in #337 (comment)

[pmaier1]

<3

[micbar]

@phil-davis Please force push to re run CI

[codecov]

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #337   +/-   ##
=========================================
  Coverage     17.87%   17.87%           
  Complexity      101      101           
=========================================
  Files            11       11           
  Lines           537      537           
=========================================
  Hits             96       96           
  Misses          441      441

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1684c6...c45147d. Read the comment docs.

[codecov]

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #337   +/-   ##
=========================================
  Coverage     17.87%   17.87%           
  Complexity      101      101           
=========================================
  Files            11       11           
  Lines           537      537           
=========================================
  Hits             96       96           
  Misses          441      441

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1684c6...c45147d. Read the comment docs.

[phil-davis]

CI is running again - let's see...

[codecov]

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #337   +/-   ##
=========================================
  Coverage     17.87%   17.87%           
  Complexity      101      101           
=========================================
  Files            11       11           
  Lines           537      537           
=========================================
  Hits             96       96           
  Misses          441      441

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1684c6...c45147d. Read the comment docs.

[codecov]

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #337   +/-   ##
=========================================
  Coverage     17.87%   17.87%           
  Complexity      101      101           
=========================================
  Files            11       11           
  Lines           537      537           
=========================================
  Hits             96       96           
  Misses          441      441

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1684c6...c45147d. Read the comment docs.

[phil-davis]

If there might be a guest app release needed before core 10.3 then it will be easiest to not merge this PR yet. But if there seems to be no reason that we will have to do a guest app release on top of 10.2.* then this could be merged right away.