build(deps-dev): bump sinon from 17.0.2 to 22.0.0#684
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
6762f07 to
2dc72ee
Compare
DeepDiver1975
left a comment
Member
There was a problem hiding this comment.
Do not merge as-is — failing CI and a conflict.
JS Unit / Javascript Unitfails on this PR (job); the same check is green on other open PRs, so thesinon ^17 → ^22major bump breaks the specs.- sinon 22 spans five majors of breaking changes; the old adapters
karma-jasmine-sinon ^1.0.4/jasmine-sinon ^0.4.0are likely incompatible with sinon 22 and need bumping/replacing too. - PR is also
CONFLICTING/DIRTY— needs a rebase on the current base branch.
Rebase, adapt specs/adapters to sinon 22, then re-run CI.
🤖 Generated with Claude Code
dj4oC
reviewed
Jul 9, 2026
dj4oC
left a comment
Contributor
There was a problem hiding this comment.
- Security: No security-relevant change — sinon is a test-only devDependency.
- Stability: Major version bump (sinon 17→22, spans 5 majors). CI is red:
JS Unit / Javascript Unitfails on this PR while green on other open PRs, confirming the bump breaks specs. The pinnedkarma-jasmine-sinon/jasmine-sinonadapters likely need bumping too. - Performance: N/A
- Test coverage: N/A (test-infra bump, not product code)
- TODOs found: 0
- Dependency touched: yes — sinon (devDependency, npm)
- CI status: red — JS Unit failing
Verdict
Do not merge as-is — needs spec/adapter fixes for the sinon 22 API before this major bump can land.
🤖 Automated review by Claude Code (security · stability · performance · coverage)
Generated by Claude Code
Member
|
@dependabot rebase |
Bumps [sinon](https://github.com/sinonjs/sinon) from 17.0.2 to 22.0.0. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/CHANGES.md) - [Commits](sinonjs/sinon@v17.0.2...v22.0.0) --- updated-dependencies: - dependency-name: sinon dependency-version: 22.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
2dc72ee to
0834891
Compare
Member
|
Holding: CI is failing (not a rebase conflict). Failing check(s): JS Unit / Javascript Unit. A rebase won't fix this — needs a human/upstream fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps sinon from 17.0.2 to 22.0.0.
Changelog
Sourced from sinon's changelog.
... (truncated)
Commits
52555af22.0.0ed911dfUpdate Ruby gems75a1e5bUpdate to Node 26197d660Update documentation on faking timers to reflect the current state of fake-ti...c5ddf80Update fake-timers@15.4: includes new Temporal APIf4ab02fUpdate updatable packages0536afcQuality: Global mutable call id can grow unbounded across long-lived processe...f4f7d93Perform additional cleanup when calling callThrough() (#2670)6199e9eimprove GitHubworkflows by introducing zizmor for monitoring (#2686)1519009Merge #2703: isolate walk state from Object prototype