build(deps-dev): bump jasmine-core from 5.13.0 to 6.3.0#688
Open
dependabot[bot] wants to merge 1 commit into
Open
build(deps-dev): bump jasmine-core from 5.13.0 to 6.3.0#688dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
Bumps [jasmine-core](https://github.com/jasmine/jasmine) from 5.13.0 to 6.3.0. - [Release notes](https://github.com/jasmine/jasmine/releases) - [Changelog](https://github.com/jasmine/jasmine/blob/main/RELEASE.md) - [Commits](jasmine/jasmine@v5.13.0...v6.3.0) --- updated-dependencies: - dependency-name: jasmine-core dependency-version: 6.3.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/jasmine-core-6.3.0
branch
from
95740b8 to
50fea43
Compare
DeepDiver1975
left a comment
DeepDiver1975
left a comment
Member
There was a problem hiding this comment.
Do not merge as-is — the major bump breaks the test suite.
JS Unit / Javascript Unitfails on this PR (job); the same check is green on other open PRs, so the failure is caused by thejasmine-core ^5 → ^6bump.- jasmine-core 6 is a major release with breaking API/runtime changes. The specs need updating for jasmine 6 before this can go in.
- Also confirm the pinned adapters (
jasmine-sinon ^0.4.0,karma-jasmine ^1.1.1) are compatible with jasmine 6, or bump them together.
Fix the specs/adapters, then re-run CI.
🤖 Generated with Claude Code
dj4oC
reviewed
Jul 9, 2026
dj4oC
left a comment
dj4oC
left a comment
Contributor
There was a problem hiding this comment.
- Security: No security-relevant change — jasmine-core is a test-only devDependency.
- Stability: Major version bump (jasmine-core 5→6). CI is red:
JS Unit / Javascript Unitfails on this PR while green elsewhere, confirming the bump breaks the spec runner. Pinned adapters (jasmine-sinon,karma-jasmine) should be checked for jasmine 6 compatibility too. - Performance: N/A
- Test coverage: N/A (test-infra bump)
- TODOs found: 0
- Dependency touched: yes — jasmine-core (devDependency, npm)
- CI status: red — JS Unit failing
Verdict
Do not merge as-is — fix specs/adapters for jasmine 6 first.
🤖 Automated review by Claude Code (security · stability · performance · coverage)
Generated by Claude Code
Member
|
Holding: CI is failing (not a rebase conflict). Failing: JS Unit / Javascript Unit. A rebase won't fix this — needs a human/upstream fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps jasmine-core from 5.13.0 to 6.3.0.
Release notes
Sourced from jasmine-core's releases.
Commits
c2ead64Bump version to 6.3.005fd5cbBump version to 6.2.1f1a4ccfImprove spec namef41dc6aMerge branch 'fix/xdescribe-pending-reason' of github.com:Aryannaik-max/jasmine91a9e97test: ensure pendingReason survives reset in xdescribe testddde63afix: add pendingReason message for xdescribefc88950Run eslint and prettier after tests even if ignore-scripts=true6166a03Check in package-lock.json031ffc8Copy 7.0.0-pre.1 release notes from branchb05ea4bBump version to 6.2.0