Skip to content

[full-ci] Use new icons and bump ODS to 12.0.0(-alpha) in accounts/settings#2929

Closed
pascalwengerter wants to merge 2 commits into
masterfrom
redesign-accounts-settings
Closed

[full-ci] Use new icons and bump ODS to 12.0.0(-alpha) in accounts/settings#2929
pascalwengerter wants to merge 2 commits into
masterfrom
redesign-accounts-settings

Conversation

@pascalwengerter

@pascalwengerter pascalwengerter commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

Description

Necessary updates in accounts & settings UIs since we're changing available icons in the ODS

Checklist:

TODO:

@pascalwengerter pascalwengerter changed the title Use new icons and bump ODS to 12.X.X-alpha in accounts/settings Use new icons and bump ODS to 12.0.0(-alpha) in accounts/settings Jan 3, 2022
@pascalwengerter

Copy link
Copy Markdown
Contributor Author

Please don't merge before the referenced web PR got merged and the new web commit ID got referenced here, otherwise the icons in accounts/settings don't work with the currently bundled web version 🚫

@wkloucek
wkloucek marked this pull request as draft January 4, 2022 09:28
@pascalwengerter
pascalwengerter force-pushed the redesign-accounts-settings branch from 7ac3654 to 680f4c9 Compare January 4, 2022 12:20
@pascalwengerter pascalwengerter changed the title Use new icons and bump ODS to 12.0.0(-alpha) in accounts/settings [full-ci] Use new icons and bump ODS to 12.0.0(-alpha) in accounts/settings Jan 4, 2022
@pascalwengerter
pascalwengerter marked this pull request as ready for review January 4, 2022 12:21
@pascalwengerter
pascalwengerter force-pushed the redesign-accounts-settings branch 2 times, most recently from 844d8f4 to 97075a1 Compare January 4, 2022 12:49
@pascalwengerter
pascalwengerter force-pushed the redesign-accounts-settings branch from 97075a1 to bf76eca Compare January 4, 2022 13:23

@kulmann kulmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should only get merged when we have it updated to the upcoming web 5.0.0. Good to have an early CI check though. Thanks for that already!

@sonarqubecloud

sonarqubecloud Bot commented Jan 6, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann

kulmann commented Feb 11, 2022

Copy link
Copy Markdown
Contributor

Superseded by #3157

@kulmann kulmann closed this Feb 11, 2022
@pascalwengerter
pascalwengerter deleted the redesign-accounts-settings branch February 14, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants