Skip to content

Add previewFileMimeTypes to defaultconfig.go#4414

Merged
AlexAndBear merged 4 commits into
masterfrom
web-config-previewFileMimeTypes
Aug 26, 2022
Merged

Add previewFileMimeTypes to defaultconfig.go#4414
AlexAndBear merged 4 commits into
masterfrom
web-config-previewFileMimeTypes

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Aug 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Enhancement: Add previewFileMimeTypes to web default config

We've added previewFileMimeTypes to the web default config, so web can determine which preview types are supported
by the backend.

Related Issue

  • Fixes <issue_link>

Motivation and Context

Part of: owncloud/web#7474

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs

update-docs Bot commented Aug 18, 2022

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear
AlexAndBear marked this pull request as ready for review August 18, 2022 11:45
@AlexAndBear
AlexAndBear requested a review from kulmann as a code owner August 18, 2022 11:45
@AlexAndBear
AlexAndBear requested a review from butonic August 18, 2022 11:45
kulmann
kulmann reviewed Aug 19, 2022
View reviewed changes
Comment thread services/web/pkg/config/defaults/defaultconfig.go Outdated
kulmann
kulmann reviewed Aug 19, 2022
View reviewed changes
Comment thread services/web/pkg/config/defaults/defaultconfig.go
@AlexAndBear
AlexAndBear requested a review from kulmann August 26, 2022 08:33
@ownclouders

ownclouders commented Aug 26, 2022

Copy link
Copy Markdown
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-3 failed. Further test are cancelled...

@sonarqubecloud

sonarqubecloud Bot commented Aug 26, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexAndBear
AlexAndBear merged commit a999dd1 into master Aug 26, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the web-config-previewFileMimeTypes branch August 26, 2022 09:51
ownclouders pushed a commit that referenced this pull request Aug 26, 2022
commit a999dd1
b80500c 
Author: Jan <j.ackermann91@gmail.com>
Date:   Fri Aug 26 11:51:33 2022 +0200

    Add previewFileMimeTypes to defaultconfig.go (#4414)

    * Add previewFileMimeTypes to defaultconfig.go

    * Add changelog item

    * Format

    * Remove obsolete hideSearchBar config setting
@micbar micbar mentioned this pull request Sep 12, 2022
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@butonic butonic Awaiting requested review from butonic
@kulmann kulmann Awaiting requested review from kulmann

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexAndBear @ownclouders @kulmann