Skip to content

combine server environment vars with explicitly set vars#16

Merged
phil-davis merged 1 commit into
masterfrom
fix_remote_env
Sep 6, 2018
Merged

combine server environment vars with explicitly set vars#16
phil-davis merged 1 commit into
masterfrom
fix_remote_env

Conversation

@patrickjahns

Copy link
Copy Markdown
Contributor

Addresses CI failures

@phil-davis phil-davis merged commit 7682fcc into master Sep 6, 2018
@phil-davis phil-davis deleted the fix_remote_env branch September 6, 2018 01:13
@phil-davis

Copy link
Copy Markdown
Contributor

Note: the problem was that the PHP proc_open() $env parameter is the only environment variables that the process receives, it is NOT bonus environment variables on top of what it would have by default. My bad for not realizing this.

The particular symptom was that when the testing app runs an occ command for us, the child process has only the few environment variable(s) (or none) that we explicitly passed. Some apps have code that checks for the environment variable CI an that should have come from the general system environment on drone, but it went AWOL.

@patrickjahns

Copy link
Copy Markdown
Contributor Author

Still suffering from the Problem that E in the variable order needs to be defined to check $_ENV var.

http://de2.php.net/manual/en/reserved.variables.environment.php#98113

@patrickjahns patrickjahns mentioned this pull request Sep 7, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants